Issue 1844053002: Add detached mode plumbing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1844053002: Add detached mode plumbing (Closed)

Created:
4 years, 8 months ago by ccameron

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add detached mode plumbing BUG=

Patch Set 1 #

Patch Set 2 : Almost almost there!! #

Patch Set 3 : And target #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -46 lines)			Patch
M	chrome/browser/ui/cocoa/browser_window_controller.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download
M	content/browser/compositor/software_output_device_mac.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host_ui_shim.cc	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_base.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_base.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_mac.mm	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/common/accelerated_surface_buffers_swapped_params_mac.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/gpu/ca_layer_tree_mac.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/gpu/ca_layer_tree_mac.mm	View	1 2	2 chunks	+41 lines, -3 lines	0 comments	Download
M	content/common/gpu/gpu_channel_manager_delegate.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/gpu/image_transport_surface_overlay_mac.h	View		3 chunks	+4 lines, -7 lines	0 comments	Download
M	content/common/gpu/image_transport_surface_overlay_mac.mm	View	1 2	7 chunks	+28 lines, -22 lines	0 comments	Download
M	content/common/gpu_host_messages.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/gpu/gpu_child_thread.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/gpu/gpu_child_thread.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/public/browser/render_widget_host_view.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/accelerated_widget_mac/accelerated_widget_mac.h	View	1 2	7 chunks	+18 lines, -0 lines	0 comments	Download
M	ui/accelerated_widget_mac/accelerated_widget_mac.mm	View	1 2	8 chunks	+121 lines, -3 lines	0 comments	Download