content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1844053002: Add detached mode plumbing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1844053002: Add detached mode plumbing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: And target Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 430b23d96dd8d32e52d84ecc04a1c8c2b6708b4e..c362db8a48289b2b4ba6b97942f6a674b5ac2ba4 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1650,6 +1650,14 @@ void RenderWidgetHostViewMac::ShutdownBrowserCompositor() {

browser_compositor_placeholder_.reset();

}

+gfx::NativeWindow RenderWidgetHostViewMac::CreateDetachedModeWindow() {

+ if (browser_compositor_) {

+ return browser_compositor_->accelerated_widget_mac()

+ ->CreateDetachedModeWindow();

+ }

+ return nil;

void RenderWidgetHostViewMac::SetActive(bool active) {

if (render_widget_host_) {

render_widget_host_->SetActive(active);