Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2258)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta
Patch Set: Let ResizeWebWidget decide whether to resize Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 75cc2fb5cbe3015ef1a4ecd215cde43cae31906a..49e964215e24c81f0ac7058f37003a423e167246 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -627,6 +627,8 @@ RenderViewImpl::RenderViewImpl(CompositorDependencies* compositor_deps,
#if defined(OS_ANDROID)
top_controls_constraints_(TOP_CONTROLS_STATE_BOTH),
#endif
+ top_controls_shrink_blink_size_(false),
+ top_controls_height_(0.f),
has_focus_(false),
has_scrolled_focused_editable_node_into_rect_(false),
main_render_frame_(nullptr),
@@ -2598,6 +2600,28 @@ void RenderViewImpl::OnMoveOrResizeStarted() {
webview()->hidePopups();
}
+void RenderViewImpl::ResizeWebWidget(const ResizeParams& params) {
+ bool resized = size_ != params.new_size ||
+ physical_backing_size_ != params.physical_backing_size ||
+ top_controls_height_ != params.top_controls_height;
+
+ size_ = params.new_size;
+ physical_backing_size_ = params.physical_backing_size;
+ top_controls_shrink_blink_size_ = params.top_controls_shrink_blink_size;
+ top_controls_height_ = params.top_controls_height;
+
+ gfx::Size new_widget_size = size_;
+ if (IsUseZoomForDSFEnabled()) {
+ new_widget_size = gfx::ScaleToCeiledSize(new_widget_size,
+ GetOriginalDeviceScaleFactor());
+ }
+
+ if (resized)
+ webview()->resizeWithTopControls(new_widget_size,
+ top_controls_height_,
+ top_controls_shrink_blink_size_);
+}
+
void RenderViewImpl::OnResize(const ResizeParams& params) {
TRACE_EVENT0("renderer", "RenderViewImpl::OnResize");
if (webview()) {

Powered by Google App Engine
This is Rietveld 408576698