third_party/WebKit/Source/web/WebPagePopupImpl.h - Issue 1844013002: Fix main thread top controls scrolling to mirror CC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.h

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta

Patch Set: Override top controls resize() in classes that override resize() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ResizeViewportAnchor.cpp ('K') | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | third_party/WebKit/Source/web/tests/VisualViewportTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPagePopupImpl.h

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.h b/third_party/WebKit/Source/web/WebPagePopupImpl.h

index 87f88dbfaa6700ade03dc601a70ba2eeae37f2fe..65f035ad460761e06fb564701af1fbe9eda04aeb 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.h

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.h

@@ -77,6 +77,7 @@ private:

void updateAllLifecyclePhases() override;

void willCloseLayerTreeView() override;

void paint(WebCanvas*, const WebRect&) override;

+ void resize(const WebSize&, float topControlsHeight, bool topControlsShrinkLayoutSize) override;

void resize(const WebSize&) override;

void close() override;

WebInputEventResult handleInputEvent(const WebInputEvent&) override;