Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.h

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta
Patch Set: Override top controls resize() in classes that override resize() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 WebPoint positionRelativeToOwner() override; 70 WebPoint positionRelativeToOwner() override;
71 void postMessage(const String& message) override; 71 void postMessage(const String& message) override;
72 void cancel(); 72 void cancel();
73 73
74 private: 74 private:
75 // WebWidget functions 75 // WebWidget functions
76 void beginFrame(double lastFrameTimeMonotonic) override; 76 void beginFrame(double lastFrameTimeMonotonic) override;
77 void updateAllLifecyclePhases() override; 77 void updateAllLifecyclePhases() override;
78 void willCloseLayerTreeView() override; 78 void willCloseLayerTreeView() override;
79 void paint(WebCanvas*, const WebRect&) override; 79 void paint(WebCanvas*, const WebRect&) override;
80 void resize(const WebSize&, float topControlsHeight, bool topControlsShrinkL ayoutSize) override;
80 void resize(const WebSize&) override; 81 void resize(const WebSize&) override;
81 void close() override; 82 void close() override;
82 WebInputEventResult handleInputEvent(const WebInputEvent&) override; 83 WebInputEventResult handleInputEvent(const WebInputEvent&) override;
83 void setFocus(bool) override; 84 void setFocus(bool) override;
84 bool isPagePopup() const override { return true; } 85 bool isPagePopup() const override { return true; }
85 bool isAcceleratedCompositingActive() const override { return m_isAccelerate dCompositingActive; } 86 bool isAcceleratedCompositingActive() const override { return m_isAccelerate dCompositingActive; }
86 87
87 // PageWidgetEventHandler functions 88 // PageWidgetEventHandler functions
88 WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override; 89 WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override;
89 WebInputEventResult handleCharEvent(const WebKeyboardEvent&) override; 90 WebInputEventResult handleCharEvent(const WebKeyboardEvent&) override;
(...skipping 30 matching lines...) Expand all
120 friend class PagePopupChromeClient; 121 friend class PagePopupChromeClient;
121 }; 122 };
122 123
123 DEFINE_TYPE_CASTS(WebPagePopupImpl, WebWidget, widget, widget->isPagePopup(), wi dget.isPagePopup()); 124 DEFINE_TYPE_CASTS(WebPagePopupImpl, WebWidget, widget, widget->isPagePopup(), wi dget.isPagePopup());
124 // WebPagePopupImpl is the only implementation of PagePopup, so no 125 // WebPagePopupImpl is the only implementation of PagePopup, so no
125 // further checking required. 126 // further checking required.
126 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true); 127 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true);
127 128
128 } // namespace blink 129 } // namespace blink
129 #endif // WebPagePopupImpl_h 130 #endif // WebPagePopupImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698