Issue 18440003: telemetry: Added timeout parameter to StartTracing.

Issue 18440003: telemetry: Added timeout parameter to StartTracing. (Closed)

Created:
7 years, 5 months ago by ernstm

Modified:
7 years, 5 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

telemetry: Added timeout parameter to StartTracing. BUG=226489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209785

Patch Set 2 : Changed default timeout to DEFAULT_WEB_CONTENTS_TIMEOUT #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	tools/telemetry/telemetry/core/browser.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/browser_backend.py	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/tracing_backend.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

ernstm

rasterize_and_record_benchmark can run for more than 10 seconds. Added an adjustable timeout to StartTracing to ...

7 years, 5 months ago (2013-07-02 00:36:23 UTC) #1

ernstm

On 2013/07/02 07:56:13, nduca wrote: > sorry, which part is running for more than 10 ...

7 years, 5 months ago (2013-07-02 17:20:35 UTC) #3

nduca

thanks for the explanation https://codereview.chromium.org/18440003/diff/1/tools/telemetry/telemetry/core/chrome/browser_backend.py File tools/telemetry/telemetry/core/chrome/browser_backend.py (right): https://codereview.chromium.org/18440003/diff/1/tools/telemetry/telemetry/core/chrome/browser_backend.py#newcode204 tools/telemetry/telemetry/core/chrome/browser_backend.py:204: def StartTracing(self, custom_categories=None, timeout=10): timeout=DEFAULT_WEB_CONTENTS_TIMEOUT ...

7 years, 5 months ago (2013-07-02 17:34:48 UTC) #4

ernstm

https://codereview.chromium.org/18440003/diff/1/tools/telemetry/telemetry/core/chrome/browser_backend.py File tools/telemetry/telemetry/core/chrome/browser_backend.py (right): https://codereview.chromium.org/18440003/diff/1/tools/telemetry/telemetry/core/chrome/browser_backend.py#newcode204 tools/telemetry/telemetry/core/chrome/browser_backend.py:204: def StartTracing(self, custom_categories=None, timeout=10): On 2013/07/02 17:34:48, nduca wrote: ...

7 years, 5 months ago (2013-07-02 18:40:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/18440003/6001

7 years, 5 months ago (2013-07-02 18:40:43 UTC) #6

Message was sent while issue was closed.

Change committed as 209785

Expand Messages | Collapse Messages