Chromium Code Reviews

Issue 184393002: Fix representation generalization for doubles. (Closed)

Created:
6 years, 9 months ago by Hannes Payer (out of office)
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix representation generalization for doubles. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19599

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+9 lines, -11 lines)
M src/property-details.h View 1 chunk +1 line, -1 line 0 comments
A + test/mjsunit/regress/regress-347909.js View 1 chunk +8 lines, -10 lines 0 comments

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 9 months ago (2014-02-28 10:57:05 UTC) #1
Toon Verwaest
lgtm with nits https://codereview.chromium.org/184393002/diff/1/test/mjsunit/regress/regress-347909.js File test/mjsunit/regress/regress-347909.js (right): https://codereview.chromium.org/184393002/diff/1/test/mjsunit/regress/regress-347909.js#newcode4 test/mjsunit/regress/regress-347909.js:4: Flags: --allow-natives-syntax https://codereview.chromium.org/184393002/diff/1/test/mjsunit/regress/regress-347909.js#newcode5 test/mjsunit/regress/regress-347909.js:5: a = ...
6 years, 9 months ago (2014-02-28 10:59:14 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/184393002/diff/1/test/mjsunit/regress/regress-347909.js File test/mjsunit/regress/regress-347909.js (right): https://codereview.chromium.org/184393002/diff/1/test/mjsunit/regress/regress-347909.js#newcode4 test/mjsunit/regress/regress-347909.js:4: On 2014/02/28 10:59:15, Toon Verwaest wrote: > Flags: --allow-natives-syntax ...
6 years, 9 months ago (2014-02-28 11:06:52 UTC) #3
Hannes Payer (out of office)
6 years, 9 months ago (2014-02-28 11:07:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r19599 (tree was closed).

Powered by Google App Engine