src/property-details.h - Issue 184393002: Fix representation generalization for doubles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/property-details.h

Issue 184393002: Fix representation generalization for doubles. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/property-details.h

diff --git a/src/property-details.h b/src/property-details.h

index 7bc553a46be211749cf1f3cac6b4e4311d419b72..3405bd904a7bc97dcbfc7afd04d96d6a3237b3b8 100644

--- a/src/property-details.h

+++ b/src/property-details.h

@@ -138,7 +138,7 @@ class Representation {

ASSERT(kind_ != kExternal);

ASSERT(other.kind_ != kExternal);

- if (IsHeapObject()) return other.IsDouble() || other.IsNone();

+ if (IsHeapObject()) return other.IsNone();

if (kind_ == kUInteger8 && other.kind_ == kInteger8) return false;

if (kind_ == kUInteger16 && other.kind_ == kInteger16) return false;

return kind_ > other.kind_;

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-347909.js » ('j') | no next file with comments »