[Chromecast] TOT build fix. Add ctime include to DumpInfo.

[Chromecast] Add ctime include to DumpInfo.

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.

Committed: https://crrev.com/dfb20ca48b33e348edfe5ee3908f8321b5920c1b
Cr-Commit-Position: refs/heads/master@{#383774}

[esum, 2016-03-29 17:33:44]

esum@chromium.org changed reviewers:
+ alokp@chromium.org, slan@chromium.org

[esum, 2016-03-29 17:33:45]

See https://codereview.chromium.org/1840663003. That's what broke it.

I'm guessing cstdlib somehow included ctime, and dump_info.h was depending on
scoped_ptr.h including cstdlib for the time_t declaration?

Anyways, that seems to fix it.

[slan, 2016-03-29 17:35:55]

lgtm, except please rm "TOT build fix" from the Commit message. Just include the
contents of the fix.

[esum, 2016-03-29 17:36:50]

Description was changed from

==========
[Chromecast] TOT build fix. Add ctime include to DumpInfo.

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.
==========

to

==========
[Chromecast] Add ctime include to DumpInfo.

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.
==========

[esum, 2016-03-29 17:39:05]

On 2016/03/29 17:35:55, slan wrote:
> lgtm, except please rm "TOT build fix" from the Commit message. Just include
the
> contents of the fix.

Done. What's the rule for future reference? I've seen people put "tot fix" or
equivalent in commit messages. Is that wrong?

[esum, 2016-03-29 17:39:41]

The CQ bit was checked by esum@chromium.org

[commit-bot: I haz the power, 2016-03-29 17:39:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843703002/1

[slan, 2016-03-29 17:52:29]

On 2016/03/29 17:39:05, esum wrote:
> On 2016/03/29 17:35:55, slan wrote:
> > lgtm, except please rm "TOT build fix" from the Commit message. Just include
> the
> > contents of the fix.
> 
> Done. What's the rule for future reference? I've seen people put "tot fix" or
> equivalent in commit messages. Is that wrong?

This is usually done in internal repos to clarify why the fix is needed.

[commit-bot: I haz the power, 2016-03-29 18:17:59]

Description was changed from

==========
[Chromecast] Add ctime include to DumpInfo.

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.
==========

to

==========
[Chromecast] Add ctime include to DumpInfo.

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.
==========

[commit-bot: I haz the power, 2016-03-29 18:18:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 18:20:00]

Description was changed from

==========
[Chromecast] Add ctime include to DumpInfo.

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.
==========

to

==========
[Chromecast] Add ctime include to DumpInfo.

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.

Committed: https://crrev.com/dfb20ca48b33e348edfe5ee3908f8321b5920c1b
Cr-Commit-Position: refs/heads/master@{#383774}
==========

[commit-bot: I haz the power, 2016-03-29 18:20:01]

Patchset 1 (id:??) landed as
https://crrev.com/dfb20ca48b33e348edfe5ee3908f8321b5920c1b
Cr-Commit-Position: refs/heads/master@{#383774}