Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1840663003: Trim scoped_ptr.h down to just #include <memory>. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
danakj, ddorwin
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim scoped_ptr.h down to just #include <memory>. BUG=554298 Committed: https://crrev.com/8ff4e5f701786c2ba0c83d20d82c747ccf347acc Cr-Commit-Position: refs/heads/master@{#383652}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Recomment #

Patch Set 3 : Compile fix (only ASAN?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -88 lines) Patch
M base/memory/scoped_ptr.h View 1 1 chunk +3 lines, -88 lines 0 comments Download
M media/filters/vp9_parser.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
dcheng
Next step: move make_scoped_ptr to ptr_util.h and update #includes. Next next pre-step: send chromium-dev psa ...
4 years, 8 months ago (2016-03-28 21:41:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/1
4 years, 8 months ago (2016-03-28 21:41:57 UTC) #4
danakj
https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h File base/memory/scoped_ptr.h (right): https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h#newcode5 base/memory/scoped_ptr.h:5: // Scopers help you manage ownership of a pointer, ...
4 years, 8 months ago (2016-03-28 21:42:55 UTC) #5
dcheng
https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h File base/memory/scoped_ptr.h (right): https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h#newcode5 base/memory/scoped_ptr.h:5: // Scopers help you manage ownership of a pointer, ...
4 years, 8 months ago (2016-03-28 21:44:42 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/20001
4 years, 8 months ago (2016-03-28 21:45:07 UTC) #8
danakj
It's... beautiful.
4 years, 8 months ago (2016-03-28 21:46:28 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/136586)
4 years, 8 months ago (2016-03-28 22:37:52 UTC) #11
dcheng
Maybe I wasn't building with the right set of defines, but also fixed a compile ...
4 years, 8 months ago (2016-03-28 22:46:03 UTC) #13
danakj
Oh, LGTM also.
4 years, 8 months ago (2016-03-28 22:46:55 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/40001
4 years, 8 months ago (2016-03-28 22:50:49 UTC) #16
ddorwin
media/ LGTM. Is this for uint8_t, etc.? If so, maybe we can use it here ...
4 years, 8 months ago (2016-03-28 23:02:14 UTC) #17
dcheng
On 2016/03/28 at 23:02:14, ddorwin wrote: > media/ LGTM. Is this for uint8_t, etc.? > ...
4 years, 8 months ago (2016-03-28 23:04:40 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/44325)
4 years, 8 months ago (2016-03-29 00:15:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/40001
4 years, 8 months ago (2016-03-29 00:41:49 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 02:04:11 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 02:05:25 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ff4e5f701786c2ba0c83d20d82c747ccf347acc
Cr-Commit-Position: refs/heads/master@{#383652}

Powered by Google App Engine
This is Rietveld 408576698