|
|
DescriptionTrim scoped_ptr.h down to just #include <memory>.
BUG=554298
Committed: https://crrev.com/8ff4e5f701786c2ba0c83d20d82c747ccf347acc
Cr-Commit-Position: refs/heads/master@{#383652}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Recomment #Patch Set 3 : Compile fix (only ASAN?) #
Messages
Total messages: 25 (9 generated)
dcheng@chromium.org changed reviewers: + danakj@chromium.org
Next step: move make_scoped_ptr to ptr_util.h and update #includes. Next next pre-step: send chromium-dev psa Next next step: sed all the things.
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/1
https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h File base/memory/scoped_ptr.h (right): https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h#ne... base/memory/scoped_ptr.h:5: // Scopers help you manage ownership of a pointer, helping you easily manage a Can you delete all the comments and just "// scoped_ptr is an alias for std::unique_ptr." also? Maybe another CL if u like.
https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h File base/memory/scoped_ptr.h (right): https://codereview.chromium.org/1840663003/diff/1/base/memory/scoped_ptr.h#ne... base/memory/scoped_ptr.h:5: // Scopers help you manage ownership of a pointer, helping you easily manage a On 2016/03/28 at 21:42:55, danakj wrote: > Can you delete all the comments and just "// scoped_ptr is an alias for std::unique_ptr." also? Maybe another CL if u like. Done.
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/20001
It's... beautiful.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
dcheng@chromium.org changed reviewers: + ddorwin@chromium.org
Maybe I wasn't building with the right set of defines, but also fixed a compile error in //media that the asan bot noticed. +ddorwin for //media
Oh, LGTM also.
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/40001
media/ LGTM. Is this for uint8_t, etc.? If so, maybe we can use it here too: https://code.google.com/p/chromium/codesearch#chromium/src/base/i18n/char_ite...
On 2016/03/28 at 23:02:14, ddorwin wrote: > media/ LGTM. Is this for uint8_t, etc.? > > If so, maybe we can use it here too: https://code.google.com/p/chromium/codesearch#chromium/src/base/i18n/char_ite... uint8_t and friends come from <stdint.h>. This is actually for off_t (which isn't defined by C or C++, it's a POSIX thing). It's quite possible there are other places missing the proper #includes, but my goal isn't to fix IWYU atm, it's just to keep everything compiling.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840663003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Trim scoped_ptr.h down to just #include <memory>. BUG=554298 ========== to ========== Trim scoped_ptr.h down to just #include <memory>. BUG=554298 Committed: https://crrev.com/8ff4e5f701786c2ba0c83d20d82c747ccf347acc Cr-Commit-Position: refs/heads/master@{#383652} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8ff4e5f701786c2ba0c83d20d82c747ccf347acc Cr-Commit-Position: refs/heads/master@{#383652} |