Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 1843663005: Change bool ignoreCache to WebFrameLoadType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index 537a6f4e25fd836fef1684e6b4920872a9848b41..139ceeadc6750e646afe6af357325dfa97d55533 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -42,6 +42,7 @@
#include "public/platform/WebReferrerPolicy.h"
#include "public/platform/WebURL.h"
#include "public/platform/WebURLRequest.h"
+#include "public/web/WebFrameLoadType.h"
#include "public/web/WebTreeScopeType.h"
struct NPObject;
@@ -337,12 +338,12 @@ public:
// Navigation ----------------------------------------------------------
// Reload the current document.
- // True |ignoreCache| explicitly bypasses caches.
- // False |ignoreCache| revalidates any existing cache entries.
- virtual void reload(bool ignoreCache = false) = 0;
+ // Note: reload() and reloadWithOverrideURL() will be deprecated.
+ // Do not use these APIs any more, but use loadRequest() instead.
+ virtual void reload(WebFrameLoadType = WebFrameLoadType::Reload) = 0;
// This is used for situations where we want to reload a different URL because of a redirect.
- virtual void reloadWithOverrideURL(const WebURL& overrideUrl, bool ignoreCache = false) = 0;
+ virtual void reloadWithOverrideURL(const WebURL& overrideUrl, WebFrameLoadType = WebFrameLoadType::Reload) = 0;
// Load the given URL.
virtual void loadRequest(const WebURLRequest&) = 0;
« no previous file with comments | « third_party/WebKit/public/web/WebClientRedirectPolicy.h ('k') | third_party/WebKit/public/web/WebRemoteFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698