Move arc_intent_helper_bridge.h from c/b/chromeos/ to components/

Move arc_intent_helper_bridge.h from c/b/chromeos/ to components/

The new ArcIntentHelperBridge implementation does not directly
depend on chrome/.

Also rename SettingsBridge to ArcSettingsService and make it
a sub class of arc::ArcService to remove its dependency on
ArcIntentHelperBridge.

BUG=591780
TEST=try

Committed: https://crrev.com/0b08bdbb12e9d6aea2c1dbc710a45bc59ef846a4
Cr-Commit-Position: refs/heads/master@{#384100}

[Yusuke Sato, 2016-03-30 05:44:44]

Patchset #2 (id:20001) has been deleted

[Yusuke Sato, 2016-03-30 05:44:55]

Patchset #2 (id:40001) has been deleted

[Yusuke Sato, 2016-03-30 15:30:37]

yusukes@chromium.org changed reviewers:
+ ben@chromium.org, lhchavez@chromium.org

[Yusuke Sato, 2016-03-30 15:30:38]

Ben, Luis, could you have a look at this? This implements Ben's suggestion at
https://codereview.chromium.org/1760773004/#msg25 (sorry for the delay, I was
swamped with ARC side tasks..)

[Ben Goodger (Google), 2016-03-30 16:12:31]

This is cool, thanks for doing it. In the future it'd be interesting to evaluate
the other things in chrome/browser/chromeos/arc as well. I know some of the
stuff in there relies on chrome profile, but maybe the others don't.

lgtm

[Luis Héctor Chávez, 2016-03-30 17:20:45]

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_settings_service.cc (right):

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_settings_service.cc:255: if
(arc_bridge_service_->state() != ArcBridgeService::State::READY) {
nit: It's probably better if you check for
|arc_bridge_service_->intent_helper()|.

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/settings_bridge_unittest.cc (left):

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/settings_bridge_unittest.cc:1: // Copyright (c) 2015
The Chromium Authors. All rights reserved.
Is it possible to move these tests to components/arc/?

https://codereview.chromium.org/1843563003/diff/60001/components/arc.gypi
File components/arc.gypi (right):

https://codereview.chromium.org/1843563003/diff/60001/components/arc.gypi#new...
components/arc.gypi:55: 'arc/intent_helper/arc_intent_helper_bridge.cc',
nit: alignment?

[Yusuke Sato, 2016-03-30 18:25:43]

Thanks for the review.

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_settings_service.cc (right):

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_settings_service.cc:255: if
(arc_bridge_service_->state() != ArcBridgeService::State::READY) {
On 2016/03/30 17:20:45, Luis Héctor Chávez wrote:
> nit: It's probably better if you check for
> |arc_bridge_service_->intent_helper()|.

Done.

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/settings_bridge_unittest.cc (left):

https://codereview.chromium.org/1843563003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/settings_bridge_unittest.cc:1: // Copyright (c) 2015
The Chromium Authors. All rights reserved.
On 2016/03/30 17:20:45, Luis Héctor Chávez wrote:
> Is it possible to move these tests to components/arc/?

Moved the test and ConvertFontSizeChromeToAndroid() function to
components/arc/intent_helper/. Done.

https://codereview.chromium.org/1843563003/diff/60001/components/arc.gypi
File components/arc.gypi (right):

https://codereview.chromium.org/1843563003/diff/60001/components/arc.gypi#new...
components/arc.gypi:55: 'arc/intent_helper/arc_intent_helper_bridge.cc',
On 2016/03/30 17:20:45, Luis Héctor Chávez wrote:
> nit: alignment?

Done. I missed this because side-by-side diff didn't show the tab. Fixed.

[Luis Héctor Chávez, 2016-03-30 20:14:34]

lgtm

https://codereview.chromium.org/1843563003/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/arc/arc_settings_service.cc (right):

https://codereview.chromium.org/1843563003/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/arc/arc_settings_service.cc:228: if
(arc_bridge_service_->state() != ArcBridgeService::State::READY) {
Ideally I'd like to remove the state() function from ArcBridgeService soonish.
It was only meant for testing purposes but it got used more and more :/ Can you
remove this and only keep the block in L232?

[Yusuke Sato, 2016-03-30 20:39:51]

https://codereview.chromium.org/1843563003/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/arc/arc_settings_service.cc (right):

https://codereview.chromium.org/1843563003/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/arc/arc_settings_service.cc:228: if
(arc_bridge_service_->state() != ArcBridgeService::State::READY) {
On 2016/03/30 20:14:34, Luis Héctor Chávez wrote:
> Ideally I'd like to remove the state() function from ArcBridgeService soonish.
> It was only meant for testing purposes but it got used more and more :/ Can
you
> remove this and only keep the block in L232?

Done.

[Yusuke Sato, 2016-03-30 20:39:59]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-03-30 20:40:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/1843563003/#ps120001
(title: "Address a comment")

[commit-bot: I haz the power, 2016-03-30 20:40:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843563003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843563003/120001

[commit-bot: I haz the power, 2016-03-30 21:40:07]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-03-30 21:42:49]

Description was changed from

==========
Move arc_intent_helper_bridge.h from c/b/chromeos/ to components/

The new ArcIntentHelperBridge implementation does not directly
depend on chrome/.

Also rename SettingsBridge to ArcSettingsService and make it
a sub class of arc::ArcService to remove its dependency on
ArcIntentHelperBridge.

BUG=591780
TEST=try
==========

to

==========
Move arc_intent_helper_bridge.h from c/b/chromeos/ to components/

The new ArcIntentHelperBridge implementation does not directly
depend on chrome/.

Also rename SettingsBridge to ArcSettingsService and make it
a sub class of arc::ArcService to remove its dependency on
ArcIntentHelperBridge.

BUG=591780
TEST=try

Committed: https://crrev.com/0b08bdbb12e9d6aea2c1dbc710a45bc59ef846a4
Cr-Commit-Position: refs/heads/master@{#384100}
==========

[commit-bot: I haz the power, 2016-03-30 21:42:51]

Patchset 5 (id:??) landed as
https://crrev.com/0b08bdbb12e9d6aea2c1dbc710a45bc59ef846a4
Cr-Commit-Position: refs/heads/master@{#384100}