third_party/WebKit/Source/core/fetch/ImageResourceObserver.h - Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ImageResource.cpp ('K') | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h b/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

index f9a31a54bba56bbf669ff92222dbebf7ab24c0e3..0684207ee01d3f64287fe9e7c8853a5580cbb13d 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

+++ b/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

@@ -41,8 +41,8 @@ public:

// because we are animating. If not null, the IntRect is the changed rect of the image.

virtual void imageChanged(ImageResource*, const IntRect* = 0) { }

- // Similar to ResourceClient::notifyFinished(), except for a slight call

- // order difference. This is to avoid an ImageResourceObserver from being

+ // Called just before ResourceClient::notifyFinished() would be called.

+ // This is to avoid an ImageResourceObserver from being

// also a ResourceClient just to be notified for load finish.

virtual void imageNotifyFinished(ImageResource*) { }