Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 23 matching lines...) Expand all
34 class IntRect; 34 class IntRect;
35 35
36 class CORE_EXPORT ImageResourceObserver { 36 class CORE_EXPORT ImageResourceObserver {
37 public: 37 public:
38 virtual ~ImageResourceObserver() {} 38 virtual ~ImageResourceObserver() {}
39 39
40 // Called whenever a frame of an image changes, either because we got more d ata from the network or 40 // Called whenever a frame of an image changes, either because we got more d ata from the network or
41 // because we are animating. If not null, the IntRect is the changed rect of the image. 41 // because we are animating. If not null, the IntRect is the changed rect of the image.
42 virtual void imageChanged(ImageResource*, const IntRect* = 0) { } 42 virtual void imageChanged(ImageResource*, const IntRect* = 0) { }
43 43
44 // Similar to ResourceClient::notifyFinished(), except for a slight call 44 // Called just before ResourceClient::notifyFinished() would be called.
45 // order difference. This is to avoid an ImageResourceObserver from being 45 // This is to avoid an ImageResourceObserver from being
46 // also a ResourceClient just to be notified for load finish. 46 // also a ResourceClient just to be notified for load finish.
47 virtual void imageNotifyFinished(ImageResource*) { } 47 virtual void imageNotifyFinished(ImageResource*) { }
48 48
49 // Called to find out if this client wants to actually display the image. Us ed to tell when we 49 // Called to find out if this client wants to actually display the image. Us ed to tell when we
50 // can halt animation. Content nodes that hold image refs for example would not render the image, 50 // can halt animation. Content nodes that hold image refs for example would not render the image,
51 // but LayoutImages would (assuming they have visibility: visible and their layout tree isn't hidden 51 // but LayoutImages would (assuming they have visibility: visible and their layout tree isn't hidden
52 // e.g., in the b/f cache or in a background tab). 52 // e.g., in the b/f cache or in a background tab).
53 virtual bool willRenderImage() { return false; } 53 virtual bool willRenderImage() { return false; }
54 54
55 // Called to get imageAnimation policy from settings 55 // Called to get imageAnimation policy from settings
56 virtual bool getImageAnimationPolicy(ImageAnimationPolicy&) { return false; } 56 virtual bool getImageAnimationPolicy(ImageAnimationPolicy&) { return false; }
57 57
58 virtual ResourcePriority computeResourcePriority() const { return ResourcePr iority(); } 58 virtual ResourcePriority computeResourcePriority() const { return ResourcePr iority(); }
59 59
60 // Name for debugging, e.g. shown in memory-infra. 60 // Name for debugging, e.g. shown in memory-infra.
61 virtual String debugName() const = 0; 61 virtual String debugName() const = 0;
62 62
63 static bool isExpectedType(ImageResourceObserver*) { return true; } 63 static bool isExpectedType(ImageResourceObserver*) { return true; }
64 }; 64 };
65 65
66 } // namespace blink 66 } // namespace blink
67 67
68 #endif 68 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698