third_party/WebKit/Source/core/fetch/ImageResource.h - Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.h

Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/fetch/ImageResource.h

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.h b/third_party/WebKit/Source/core/fetch/ImageResource.h

index a5b61bd64a86aeb15d6c1569fbc28c3db81b538e..2b6b439f7c115a0153ddf61a9f46cb1e78321b42 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.h

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.h

@@ -157,8 +157,11 @@ private:

void updateImage(bool allDataReceived);

void clearImage();

// If not null, changeRect is the changed part of the image.

- void notifyObservers(bool isNotifyingFinish, const IntRect* changeRect = nullptr);

- void notifyObserver(ImageResourceObserver*, bool isNotifyingFinish, const IntRect* changeRect = nullptr);

+ void notifyObservers(const IntRect* changeRect = nullptr);

+ void didAddObserver(ImageResourceObserver*);

+ void checkNotify() override;

+ void markClientsAndObserversFinished() override;

float m_devicePixelRatioHeaderValue;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/ImageResource.cpp » ('j') | third_party/WebKit/Source/core/fetch/ImageResource.cpp » ('J')