Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ImageResource.h

Issue 1843533005: Call imageNotifyFinished() just before ResourceClient::notifyFinished() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 }; 150 };
151 ImageResource(const ResourceRequest&, const ResourceLoaderOptions&); 151 ImageResource(const ResourceRequest&, const ResourceLoaderOptions&);
152 152
153 void clear(); 153 void clear();
154 154
155 void setCustomAcceptHeader(); 155 void setCustomAcceptHeader();
156 void createImage(); 156 void createImage();
157 void updateImage(bool allDataReceived); 157 void updateImage(bool allDataReceived);
158 void clearImage(); 158 void clearImage();
159 // If not null, changeRect is the changed part of the image. 159 // If not null, changeRect is the changed part of the image.
160 void notifyObservers(bool isNotifyingFinish, const IntRect* changeRect = nul lptr); 160 void notifyObservers(const IntRect* changeRect = nullptr);
161 void notifyObserver(ImageResourceObserver*, bool isNotifyingFinish, const In tRect* changeRect = nullptr); 161 void didAddObserver(ImageResourceObserver*);
162
163 void checkNotify() override;
164 void markClientsAndObserversFinished() override;
162 165
163 float m_devicePixelRatioHeaderValue; 166 float m_devicePixelRatioHeaderValue;
164 167
165 Member<MultipartImageResourceParser> m_multipartParser; 168 Member<MultipartImageResourceParser> m_multipartParser;
166 RefPtr<blink::Image> m_image; 169 RefPtr<blink::Image> m_image;
167 MultipartParsingState m_multipartParsingState = MultipartParsingState::Waiti ngForFirstPart; 170 MultipartParsingState m_multipartParsingState = MultipartParsingState::Waiti ngForFirstPart;
168 bool m_hasDevicePixelRatioHeaderValue; 171 bool m_hasDevicePixelRatioHeaderValue;
169 HashCountedSet<ImageResourceObserver*> m_observers; 172 HashCountedSet<ImageResourceObserver*> m_observers;
170 HashCountedSet<ImageResourceObserver*> m_finishedObservers; 173 HashCountedSet<ImageResourceObserver*> m_finishedObservers;
171 }; 174 };
172 175
173 DEFINE_RESOURCE_TYPE_CASTS(Image); 176 DEFINE_RESOURCE_TYPE_CASTS(Image);
174 177
175 } // namespace blink 178 } // namespace blink
176 179
177 #endif 180 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698