Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 18435007: pdf viewer: refactor and fix a bug (SkPdfobject should not reset on destruct) (Closed)

Created:
7 years, 5 months ago by edisonn
Modified:
7 years, 5 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

pdf viewer: refactor, add -w parameter to pdfviewer, add -n to remove extenassion page when there is a single page (so skdiff can be run easily) and fix a bug (SkPdfobject should not reset on destruct) Committed: https://code.google.com/p/skia/source/detail?r=9983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -2222 lines) Patch
M experimental/PdfViewer/SkPdfFont.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D experimental/PdfViewer/SkPdfParser.h View 1 chunk +0 lines, -88 lines 0 comments Download
D experimental/PdfViewer/SkPdfParser.cpp View 1 chunk +0 lines, -1909 lines 0 comments Download
A + experimental/PdfViewer/SkPdfRenderer.h View 1 chunk +14 lines, -61 lines 0 comments Download
A + experimental/PdfViewer/SkPdfRenderer.cpp View 5 chunks +149 lines, -37 lines 0 comments Download
M experimental/PdfViewer/pdf_viewer_main.cpp View 12 chunks +78 lines, -40 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp View 4 chunks +4 lines, -69 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp View 5 chunks +20 lines, -12 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfObject.h View 2 chunks +4 lines, -4 lines 0 comments Download
M gyp/pdfviewer.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
edisonn
7 years, 5 months ago (2013-07-10 22:33:15 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r9983.

Powered by Google App Engine
This is Rietveld 408576698