experimental/PdfViewer/pdfparser/native/SkPdfObject.h - Issue 18435007: pdf viewer: refactor and fix a bug (SkPdfobject should not reset on destruct)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/pdfparser/native/SkPdfObject.h

Issue 18435007: pdf viewer: refactor and fix a bug (SkPdfobject should not reset on destruct) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: experimental/PdfViewer/pdfparser/native/SkPdfObject.h

===================================================================

--- experimental/PdfViewer/pdfparser/native/SkPdfObject.h (revision 9970)

+++ experimental/PdfViewer/pdfparser/native/SkPdfObject.h (working copy)

@@ -86,7 +86,7 @@

public:

- SkPdfObject() : fObjectType(kInvalid_PdfObjectType), fData(NULL) {}

+ SkPdfObject() : fObjectType(kInvalid_PdfObjectType), fMap(NULL), fData(NULL) {}

inline void* data() {

return fData;

@@ -96,9 +96,9 @@

fData = data;

}

- ~SkPdfObject() {

- reset();

- }

+// ~SkPdfObject() {

+// //reset(); must be called manually!

+// }

void reset() {

switch (fObjectType) {

« no previous file with comments | « experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp ('k') | gyp/pdfviewer.gyp » ('j') | no next file with comments »