Add a method to query whether printing is active.

Add a method to query whether printing is active.

relevant downstream link: 
https://chrome-internal-review.googlesource.com/#/c/156479/

BUG=344057
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255994

[cimamoglu (inactive), 2014-03-07 11:52:21]

lgtm

Please add BUG=344057 to the commit message. One small comment, other than that
LGTM.

https://codereview.chromium.org/184343013/diff/20001/printing/android/java/sr...
File printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java
(right):

https://codereview.chromium.org/184343013/diff/20001/printing/android/java/sr...
printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java:177:
mPrintManager = printManager;
I don't think we need the mPrintManager member variable any more, please remove
it.

[cimamoglu (inactive), 2014-03-07 11:53:55]

dtrainor@chromium.org: for OWNERS 

Also, please add the relevant downstream CL link to the commit message.

[sgurun-gerrit only, 2014-03-07 18:38:31]

On 2014/03/07 11:53:55, cimamoglu wrote:
> dtrainor@chromium.org: for OWNERS 
> 
> Also, please add the relevant downstream CL link to the commit message.

thanks! @dtrainor need code review for chrome/android

[sgurun-gerrit only, 2014-03-07 18:38:41]

https://codereview.chromium.org/184343013/diff/20001/printing/android/java/sr...
File printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java
(right):

https://codereview.chromium.org/184343013/diff/20001/printing/android/java/sr...
printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java:177:
mPrintManager = printManager;
On 2014/03/07 11:52:21, cimamoglu wrote:
> I don't think we need the mPrintManager member variable any more, please
remove
> it.

Done.

[David Trainor- moved to gerrit, 2014-03-08 00:34:13]

lgtm thanks!

[sgurun-gerrit only, 2014-03-10 14:38:31]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2014-03-10 14:38:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/184343013/40001

[commit-bot: I haz the power, 2014-03-10 17:11:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/184343013/40001

[commit-bot: I haz the power, 2014-03-10 17:45:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/184343013/40001

[commit-bot: I haz the power, 2014-03-10 18:40:10]

Change committed as 255994

[newt (away), 2014-03-11 22:06:56]

Question about an Android lint error caused by this CL:

Context.PRINT_SERVICE was added in KitKat, so mPrintManager in
PrintManagerDelegateImpl.java will be null on earlier platforms. Are we ensuring
that we're on version 19 or higher before we construct the
PrintManagerDelegateImpl so we don't crash on earlier versions of Android? If
so, we can just suppress the warning. If not, we should fix that. Thanks!

Android lint output:

printing/android/java/src/org/chromium/printing/PrintManagerDelegateImpl.java:19
Error: Field requires API level 19 (current min is 14):
android.content.Context#PRINT_SERVICE [InlinedApi]
        mPrintManager =  (PrintManager)
context.getSystemService(Context.PRINT_SERVICE);

[sgurun-gerrit only, 2014-03-11 22:40:19]

On 2014/03/11 22:06:56, newt wrote:
> Question about an Android lint error caused by this CL:
> 
> Context.PRINT_SERVICE was added in KitKat, so mPrintManager in
> PrintManagerDelegateImpl.java will be null on earlier platforms. Are we
ensuring
> that we're on version 19 or higher before we construct the
> PrintManagerDelegateImpl so we don't crash on earlier versions of Android? If
> so, we can just suppress the warning. If not, we should fix that. Thanks!
> 
> Android lint output:
> 
>
printing/android/java/src/org/chromium/printing/PrintManagerDelegateImpl.java:19
> Error: Field requires API level 19 (current min is 14):
> android.content.Context#PRINT_SERVICE [InlinedApi]
>         mPrintManager =  (PrintManager)
> context.getSystemService(Context.PRINT_SERVICE);

good point. We do check for it (downstream) but it is slightly indirectly. We
check the API level before creating printingcontroller, and then we check
whether printing controller is created before creating the delegate
implementation.

I can try to improve on this by adding another check to a more proper location.

[newt (away), 2014-03-11 23:58:12]

On 2014/03/11 22:40:19, sgurun wrote:
> On 2014/03/11 22:06:56, newt wrote:
> > Question about an Android lint error caused by this CL:
> > 
> > Context.PRINT_SERVICE was added in KitKat, so mPrintManager in
> > PrintManagerDelegateImpl.java will be null on earlier platforms. Are we
> ensuring
> > that we're on version 19 or higher before we construct the
> > PrintManagerDelegateImpl so we don't crash on earlier versions of Android?
If
> > so, we can just suppress the warning. If not, we should fix that. Thanks!
> > 
> > Android lint output:
> > 
> >
>
printing/android/java/src/org/chromium/printing/PrintManagerDelegateImpl.java:19
> > Error: Field requires API level 19 (current min is 14):
> > android.content.Context#PRINT_SERVICE [InlinedApi]
> >         mPrintManager =  (PrintManager)
> > context.getSystemService(Context.PRINT_SERVICE);
> 
> good point. We do check for it (downstream) but it is slightly indirectly. We
> check the API level before creating printingcontroller, and then we check
> whether printing controller is created before creating the delegate
> implementation.
> 
> I can try to improve on this by adding another check to a more proper
location.

Sounds good. Thanks!