chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java - Issue 184343013: Add a method to query whether printing is active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 184343013: Add a method to query whether printing is active. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed code review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java ('k') | printing/android/java/src/org/chromium/printing/PrintManagerDelegateImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

index e68e396813f89c8887068eae0321690f4d01e1b7..78f4b7f1d5dd0f25c5be9d7d53b06a24739352c3 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

@@ -33,6 +33,7 @@ import org.chromium.content.browser.ActivityContentVideoViewClient;

import org.chromium.content.browser.BrowserStartupController;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.DeviceUtils;

+import org.chromium.printing.PrintManagerDelegateImpl;

import org.chromium.printing.PrintingController;

import org.chromium.sync.signin.ChromeSigninController;

import org.chromium.ui.base.ActivityWindowAndroid;

@@ -232,7 +233,8 @@ public class ChromeShellActivity extends Activity implements AppMenuPropertiesDe

return true;

case R.id.print:

if (getActiveTab() != null) {

- mPrintingController.startPrint(new TabPrinter(getActiveTab()));

+ mPrintingController.startPrint(new TabPrinter(getActiveTab()),

+ new PrintManagerDelegateImpl(this));

}

return true;

case R.id.distill_page: