Move Position printer to Pointer.cpp

Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests and removes "CoreTestPrinters.cpp" since it is now empty.

Note: crrev.com/383236 moves |Node| printer to "Node.cpp" from
"CoreTestPrinters.cpp"

BUG=596760
TEST=n/a; no behavior changes

Committed: https://crrev.com/db675b5b6f9d0e08c13908c6ec73546ee912e2ed
Cr-Commit-Position: refs/heads/master@{#384238}

[yosin_UTC9, 2016-03-31 07:13:50]

Description was changed from

==========
2016-03-31T16:10:18

BUG=n/a
==========

to

==========
Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-03-31 07:13:50]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-03-31 07:16:26]

Description was changed from

==========
Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests and removes "CoreTestPrinters.cpp" since it is now empty.

Note: crrev.com/383236 moves |Node| printer to "Node.cpp" from 
"CoreTestPrinters.cpp"

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-03-31 07:16:39]

PTAL

[tkent, 2016-03-31 07:59:58]

lgtm

https://codereview.chromium.org/1843403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/Position.cpp (right):

https://codereview.chromium.org/1843403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Position.cpp:33: #include <ostream> //
NOLINT
please sort headers in the alphabetical order.

BTW, using <ostream> is totally valid now.  We should remove the check.

[yosin_UTC9, 2016-03-31 08:25:00]

Description was changed from

==========
Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests and removes "CoreTestPrinters.cpp" since it is now empty.

Note: crrev.com/383236 moves |Node| printer to "Node.cpp" from 
"CoreTestPrinters.cpp"

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests and removes "CoreTestPrinters.cpp" since it is now empty.

Note: crrev.com/383236 moves |Node| printer to "Node.cpp" from 
"CoreTestPrinters.cpp"

BUG=596760
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-03-31 08:31:27]

https://codereview.chromium.org/1843403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/Position.cpp (right):

https://codereview.chromium.org/1843403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Position.cpp:33: #include <ostream> //
NOLINT
Per discussion offline. We'll commit as is.

Here is summary of discussion:

On 2016/03/31 at 07:59:58, tkent wrote:
> please sort headers in the alphabetical order.
> 
> BTW, using <ostream> is totally valid now.  We should remove the check.

It seems "check-webkit-style" doesn't handle this case.

I tried following:
 - <ostream> then <stdio.h>; "check-webkit-style" stops with KeyError: 32
 - <ostream> NOLINT(readability/streams) then <stdio.h>; "check-webkit-style"
stops with KeyError: 32
 - <stdio.h> <ostream> before all include; build/include_order

So, at this time, we can't follow Blink's rule, alphabetical sorting include
directive.
Note: Google C++ style guide says C++ system header should come after C++ system
header.

BTW, I'll remove <stdio.h> once I replace usage of stdio in Position.cpp

[yosin_UTC9, 2016-03-31 08:31:30]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-03-31 08:31:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843403002/1

[commit-bot: I haz the power, 2016-03-31 10:25:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-31 10:27:15]

Description was changed from

==========
Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests and removes "CoreTestPrinters.cpp" since it is now empty.

Note: crrev.com/383236 moves |Node| printer to "Node.cpp" from 
"CoreTestPrinters.cpp"

BUG=596760
TEST=n/a; no behavior changes
==========

to

==========
Move Position printer to Pointer.cpp

This patch moves |Position| printer implementation to "Pointer.cpp" from
"CoreTestPrinters.cpp" to utilize |Position| printer with |DCHECK()| macros
other than unit tests and removes "CoreTestPrinters.cpp" since it is now empty.

Note: crrev.com/383236 moves |Node| printer to "Node.cpp" from
"CoreTestPrinters.cpp"

BUG=596760
TEST=n/a; no behavior changes

Committed: https://crrev.com/db675b5b6f9d0e08c13908c6ec73546ee912e2ed
Cr-Commit-Position: refs/heads/master@{#384238}
==========

[commit-bot: I haz the power, 2016-03-31 10:27:16]

Patchset 1 (id:??) landed as
https://crrev.com/db675b5b6f9d0e08c13908c6ec73546ee912e2ed
Cr-Commit-Position: refs/heads/master@{#384238}