Move Position printer to Pointer.cpp

third_party/WebKit/Source/core/editing/Position.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/editing/Position.h"
 
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/TextAffinity.h"
 #include "wtf/text/CString.h"
 #include <stdio.h>
+#include <ostream> // NOLINT

[tkent, 2016/03/31 07:59:58]

please sort headers in the alphabetical order.

BTW, using <ostream> is totally valid now.  We should remove the check.

[yosin_UTC9, 2016/03/31 08:31:27]

Per discussion offline. We'll commit as is.

Here is summary of discussion:

On 2016/03/31 at 07:59:58, tkent wrote:
It seems "check-webkit-style" doesn't handle this case.

I tried following:
 - <ostream> then <stdio.h>; "check-webkit-style" stops with KeyError: 32
 - <ostream> NOLINT(readability/streams) then <stdio.h>; "check-webkit-style"
stops with KeyError: 32
 - <stdio.h> <ostream> before all include; build/include_order

So, at this time, we can't follow Blink's rule, alphabetical sorting include
directive.
Note: Google C++ style guide says C++ system header should come after C++ system
header.

BTW, I'll remove <stdio.h> once I replace usage of stdio in Position.cpp

 
 namespace blink {
 
 #if ENABLE(ASSERT)
 static bool canBeAnchorNode(Node* node)
 {
     return !node || !node->isPseudoElement();
 }
 #endif
 
@@ skipping 473 matching lines @@
 void PositionTemplate<Strategy>::showTreeForThisInFlatTree() const
 {
     if (!anchorNode())
         return;
     anchorNode()->showTreeForThisInFlatTree();
     showAnchorTypeAndOffset();
 }
 
 #endif
 
+template <typename PositionType>
+static std::ostream& printPosition(std::ostream& ostream, const PositionType& position)
+{
+    if (position.isNull())
+        return ostream << "null";
+    ostream << position.anchorNode() << "@";
+    if (position.isOffsetInAnchor())
+        return ostream << position.offsetInContainerNode();
+    return ostream << position.anchorType();
+}
+
+std::ostream& operator<<(std::ostream& ostream, PositionAnchorType anchorType)
+{
+    switch (anchorType) {
+    case PositionAnchorType::AfterAnchor:
+        return ostream << "afterAnchor";
+    case PositionAnchorType::AfterChildren:
+        return ostream << "afterChildren";
+    case PositionAnchorType::BeforeAnchor:
+        return ostream << "beforeAnchor";
+    case PositionAnchorType::BeforeChildren:
+        return ostream << "beforeChildren";
+    case PositionAnchorType::OffsetInAnchor:
+        return ostream << "offsetInAnchor";
+    }
+    NOTREACHED();
+    return ostream << "anchorType=" << static_cast<int>(anchorType);
+}
+
+std::ostream& operator<<(std::ostream& ostream, const Position& position)
+{
+    return printPosition(ostream, position);
+}
+
+std::ostream& operator<<(std::ostream& ostream, const PositionInFlatTree& position)
+{
+    return printPosition(ostream, position);
+}
+
 template class CORE_TEMPLATE_EXPORT PositionTemplate<EditingStrategy>;
 template class CORE_TEMPLATE_EXPORT PositionTemplate<EditingInFlatTreeStrategy>;
 
 } // namespace blink
 
 #ifndef NDEBUG
 
 void showTree(const blink::Position& pos)
 {
     pos.showTreeForThis();
 }
 
 void showTree(const blink::Position* pos)
 {
     if (pos)
         pos->showTreeForThis();
     else
         fprintf(stderr, "Cannot showTree for (nil)\n");
 }
 
 #endif