Safe Browsing: CheckApiBlacklist request implementation

components/safe_browsing_db/test_database_manager.h

Index: components/safe_browsing_db/test_database_manager.h
diff --git a/components/safe_browsing_db/test_database_manager.h b/components/safe_browsing_db/test_database_manager.h
index c56e683c3744b1be1ddc9a61a99afd4ad37f4598..56b0a3ade062f1199d3208deffac42ff30d0d814 100644
--- a/components/safe_browsing_db/test_database_manager.h
+++ b/components/safe_browsing_db/test_database_manager.h
@@ -21,7 +21,8 @@ struct V4ProtocolConfig;
 
 // This is a non-pure-virtual implementation of the SafeBrowsingDatabaseManager
 // interface.  It's used in tests by overriding only the functions that get
-// called, and it'll complain if you call one that isn't overriden.
+// called, and it'll complain if you call one that isn't overriden. The
+// non-abstract methods in the base class are not overridden.

[Nathan Parker, 2016/04/07 21:33:38]

This changes the model a bit, since now tests may accidentally call real
implementations of things w/o check-failing.   I"m not convinced that's a
problem, but something to be aware of.  The trade off is that this class
requires touching every time we add a new method, which is slightly cumbersome. 
What do you think?

[kcarattini, 2016/04/11 03:34:31]

What I've done seemed like a reasonable solution to me. 
I checked that none of the current subclasses are calling the non-abstract
methods except for LocalDatabaseManager, and that class' test is not
significantly impacted (it just creates and destroys the V4 PM on start/stop). I
anticipate future subclasses to be similar.

The class still requires touching every time we add a non-abstract method,
though.

 class TestSafeBrowsingDatabaseManager
     : public SafeBrowsingDatabaseManager {
  public:
@@ -47,11 +48,6 @@ class TestSafeBrowsingDatabaseManager
   bool IsMalwareKillSwitchOn() override;
   bool IsCsdWhitelistKillSwitchOn() override;
   void CancelCheck(Client* client) override;
-  void CheckApiBlacklistUrl(const GURL& url, Client* client) override;
-  void StartOnIOThread(
-      net::URLRequestContextGetter* request_context_getter,
-      const V4ProtocolConfig& config) override;
-  void StopOnIOThread(bool shutdown) override;
 
  protected:
   ~TestSafeBrowsingDatabaseManager() override {};