Safe Browsing: CheckApiBlacklist request implementation

components/safe_browsing_db/test_database_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_TEST_DATABASE_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_TEST_DATABASE_MANAGER_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "components/safe_browsing_db/database_manager.h"
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 namespace safe_browsing {
 
 struct V4ProtocolConfig;
 
 // This is a non-pure-virtual implementation of the SafeBrowsingDatabaseManager
 // interface.  It's used in tests by overriding only the functions that get
-// called, and it'll complain if you call one that isn't overriden.
+// called, and it'll complain if you call one that isn't overriden. The
+// non-abstract methods in the base class are not overridden.

[Nathan Parker, 2016/04/07 21:33:38]

This changes the model a bit, since now tests may accidentally call real
implementations of things w/o check-failing.   I"m not convinced that's a
problem, but something to be aware of.  The trade off is that this class
requires touching every time we add a new method, which is slightly cumbersome. 
What do you think?

[kcarattini, 2016/04/11 03:34:31]

What I've done seemed like a reasonable solution to me. 
I checked that none of the current subclasses are calling the non-abstract
methods except for LocalDatabaseManager, and that class' test is not
significantly impacted (it just creates and destroys the V4 PM on start/stop). I
anticipate future subclasses to be similar.

The class still requires touching every time we add a non-abstract method,
though.

 class TestSafeBrowsingDatabaseManager
     : public SafeBrowsingDatabaseManager {
  public:
   // SafeBrowsingDatabaseManager implementation:
   bool IsSupported() const override;
   safe_browsing::ThreatSource GetThreatSource() const override;
   bool ChecksAreAlwaysAsync() const override;
   bool CanCheckResourceType(content::ResourceType resource_type) const override;
   bool CanCheckUrl(const GURL& url) const override;
   bool download_protection_enabled() const override;
   bool CheckBrowseUrl(const GURL& url, Client* client) override;
   bool CheckDownloadUrl(const std::vector<GURL>& url_chain,
                         Client* client) override;
   bool CheckExtensionIDs(const std::set<std::string>& extension_ids,
                          Client* client) override;
   bool CheckResourceUrl(const GURL& url, Client* client) override;
   bool MatchCsdWhitelistUrl(const GURL& url) override;
   bool MatchMalwareIP(const std::string& ip_address) override;
   bool MatchDownloadWhitelistUrl(const GURL& url) override;
   bool MatchDownloadWhitelistString(const std::string& str) override;
   bool MatchInclusionWhitelistUrl(const GURL& url) override;
   bool MatchModuleWhitelistString(const std::string& str) override;
   bool IsMalwareKillSwitchOn() override;
   bool IsCsdWhitelistKillSwitchOn() override;
   void CancelCheck(Client* client) override;
-  void CheckApiBlacklistUrl(const GURL& url, Client* client) override;
-  void StartOnIOThread(
-      net::URLRequestContextGetter* request_context_getter,
-      const V4ProtocolConfig& config) override;
-  void StopOnIOThread(bool shutdown) override;
 
  protected:
   ~TestSafeBrowsingDatabaseManager() override {};
 };
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_TEST_DATABASE_MANAGER_H_