Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1843333003: Update NSPR to 4.12 and NSS to 3.23 on iOS (Closed)

Created:
4 years, 8 months ago by Ryan Sleevi
Modified:
4 years, 8 months ago
Reviewers:
svaldez
CC:
chromium-reviews, davidben
Base URL:
https://chromium.googlesource.com/chromium/deps/nss.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update NSPR to 4.12 and NSS to 3.23 on iOS This has no effect until DEPS are updated. Note: This removes support for compiling on Mac/Win, as they are no longer supported NSS targets by Chromium. Only the iOS buildsystem is kept. R=svaldez@chromium.org BUG=600619 Committed: https://chromium.googlesource.com/chromium/deps/nss/+/9014ff711cae72152f811056b333062664ed82ac

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34724 lines, -41043 lines) Patch
M README.chromium View 2 chunks +0 lines, -7 lines 0 comments Download
M nspr/lib/ds/plarena.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nspr/pr/include/md/_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M nspr/pr/include/md/_unixos.h View 1 chunk +1 line, -1 line 0 comments Download
M nspr/pr/include/prenv.h View 1 chunk +14 lines, -0 lines 0 comments Download
M nspr/pr/include/prinit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nspr/pr/src/io/prlog.c View 1 chunk +1 line, -7 lines 0 comments Download
M nspr/pr/src/io/prprf.c View 6 chunks +28 lines, -6 lines 0 comments Download
M nspr/pr/src/io/prscanf.c View 2 chunks +2 lines, -2 lines 0 comments Download
M nspr/pr/src/md/unix/unix.c View 2 chunks +2 lines, -2 lines 0 comments Download
M nspr/pr/src/md/windows/ntinrval.c View 1 chunk +4 lines, -0 lines 0 comments Download
M nspr/pr/src/md/windows/w95thred.c View 2 chunks +6 lines, -1 line 0 comments Download
M nspr/pr/src/misc/prenv.c View 3 chunks +35 lines, -0 lines 0 comments Download
M nspr/pr/src/misc/prnetdb.c View 1 chunk +1 line, -2 lines 0 comments Download
M nspr/pr/src/misc/prtpool.c View 1 chunk +2 lines, -2 lines 0 comments Download
M nspr/pr/src/misc/prtrace.c View 1 chunk +1 line, -7 lines 0 comments Download
M nspr/pr/src/pthreads/ptio.c View 3 chunks +3 lines, -3 lines 0 comments Download
M nspr/pr/src/pthreads/ptthread.c View 3 chunks +9 lines, -3 lines 0 comments Download
M nss.gyp View 24 chunks +11 lines, -327 lines 0 comments Download
D nss/exports_win.def View 1 chunk +0 lines, -307 lines 0 comments Download
M nss/lib/base/arena.c View 24 chunks +571 lines, -642 lines 0 comments Download
M nss/lib/base/base.h View 61 chunks +157 lines, -445 lines 0 comments Download
M nss/lib/base/baset.h View 4 chunks +19 lines, -20 lines 0 comments Download
M nss/lib/base/error.c View 9 chunks +98 lines, -98 lines 0 comments Download
M nss/lib/base/errorval.c View 2 chunks +3 lines, -0 lines 0 comments Download
M nss/lib/base/hash.c View 12 chunks +144 lines, -201 lines 0 comments Download
M nss/lib/base/hashops.c View 1 chunk +25 lines, -45 lines 0 comments Download
M nss/lib/base/item.c View 4 chunks +70 lines, -92 lines 0 comments Download
M nss/lib/base/libc.c View 5 chunks +45 lines, -66 lines 0 comments Download
M nss/lib/base/list.c View 15 chunks +128 lines, -128 lines 0 comments Download
M nss/lib/base/nssbase.h View 11 chunks +31 lines, -64 lines 0 comments Download
M nss/lib/base/nssbaset.h View 4 chunks +10 lines, -11 lines 0 comments Download
M nss/lib/base/nssutf8.c View 9 chunks +420 lines, -467 lines 0 comments Download
M nss/lib/base/tracker.c View 11 chunks +156 lines, -189 lines 0 comments Download
M nss/lib/certdb/alg1485.c View 19 chunks +882 lines, -866 lines 0 comments Download
M nss/lib/certdb/cert.h View 51 chunks +433 lines, -535 lines 0 comments Download
M nss/lib/certdb/certdb.h View 4 chunks +34 lines, -43 lines 0 comments Download
M nss/lib/certdb/certdb.c View 85 chunks +1448 lines, -1486 lines 0 comments Download
M nss/lib/certdb/certi.h View 14 chunks +93 lines, -111 lines 0 comments Download
M nss/lib/certdb/certt.h View 38 chunks +385 lines, -406 lines 0 comments Download
M nss/lib/certdb/certv3.c View 9 chunks +71 lines, -75 lines 0 comments Download
M nss/lib/certdb/certxutl.h View 2 chunks +13 lines, -19 lines 0 comments Download
M nss/lib/certdb/certxutl.c View 10 chunks +197 lines, -201 lines 0 comments Download
M nss/lib/certdb/crl.c View 106 chunks +831 lines, -1161 lines 0 comments Download
M nss/lib/certdb/genname.h View 1 chunk +35 lines, -48 lines 0 comments Download
M nss/lib/certdb/genname.c View 53 chunks +812 lines, -811 lines 0 comments Download
M nss/lib/certdb/polcyxtn.c View 19 chunks +329 lines, -352 lines 0 comments Download
M nss/lib/certdb/secname.c View 22 chunks +349 lines, -342 lines 0 comments Download
M nss/lib/certdb/stanpcertdb.c View 29 chunks +401 lines, -432 lines 0 comments Download
M nss/lib/certdb/xauthkid.c View 3 chunks +77 lines, -77 lines 0 comments Download
M nss/lib/certdb/xbsconst.c View 2 chunks +94 lines, -92 lines 0 comments Download
M nss/lib/certdb/xconst.h View 1 chunk +11 lines, -17 lines 0 comments Download
M nss/lib/certdb/xconst.c View 10 chunks +86 lines, -103 lines 0 comments Download
M nss/lib/certhigh/certhigh.c View 30 chunks +596 lines, -583 lines 0 comments Download
M nss/lib/certhigh/certhtml.c View 3 chunks +210 lines, -209 lines 0 comments Download
M nss/lib/certhigh/certreq.c View 9 chunks +100 lines, -93 lines 0 comments Download
M nss/lib/certhigh/certvfy.c View 34 chunks +1153 lines, -1155 lines 0 comments Download
M nss/lib/certhigh/certvfypkix.c View 66 chunks +689 lines, -700 lines 0 comments Download
M nss/lib/certhigh/crlv2.c View 5 chunks +47 lines, -47 lines 0 comments Download
M nss/lib/certhigh/ocsp.h View 22 chunks +52 lines, -55 lines 0 comments Download
M nss/lib/certhigh/ocsp.c View 215 chunks +1402 lines, -1468 lines 0 comments Download
M nss/lib/certhigh/ocspi.h View 5 chunks +20 lines, -18 lines 0 comments Download
M nss/lib/certhigh/ocspsig.c View 16 chunks +184 lines, -187 lines 0 comments Download
M nss/lib/certhigh/ocspt.h View 9 chunks +64 lines, -64 lines 0 comments Download
M nss/lib/certhigh/ocspti.h View 15 chunks +55 lines, -58 lines 0 comments Download
M nss/lib/certhigh/xcrldist.c View 1 chunk +157 lines, -159 lines 0 comments Download
M nss/lib/ckfw/builtins/anchor.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/ckfw/builtins/bfind.c View 1 chunk +191 lines, -201 lines 0 comments Download
M nss/lib/ckfw/builtins/binst.c View 2 chunks +44 lines, -56 lines 0 comments Download
M nss/lib/ckfw/builtins/bobject.c View 1 chunk +137 lines, -153 lines 0 comments Download
M nss/lib/ckfw/builtins/bsession.c View 1 chunk +47 lines, -51 lines 0 comments Download
M nss/lib/ckfw/builtins/bslot.c View 1 chunk +47 lines, -57 lines 0 comments Download
M nss/lib/ckfw/builtins/btoken.c View 1 chunk +89 lines, -105 lines 0 comments Download
M nss/lib/ckfw/builtins/builtins.h View 1 chunk +30 lines, -36 lines 0 comments Download
M nss/lib/ckfw/builtins/certdata.c View 387 chunks +689 lines, -1696 lines 0 comments Download
M nss/lib/ckfw/builtins/ckbiver.c View 1 chunk +1 line, -2 lines 0 comments Download
M nss/lib/ckfw/builtins/constants.c View 1 chunk +28 lines, -25 lines 0 comments Download
M nss/lib/ckfw/builtins/nssckbi.h View 2 chunks +4 lines, -4 lines 0 comments Download
M nss/lib/ckfw/ckfw.h View 15 chunks +622 lines, -999 lines 0 comments Download
M nss/lib/ckfw/ckfwm.h View 1 chunk +25 lines, -41 lines 0 comments Download
M nss/lib/ckfw/ckfwtm.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/ckfw/ckmd.h View 1 chunk +11 lines, -15 lines 0 comments Download
M nss/lib/ckfw/crypto.c View 2 chunks +193 lines, -215 lines 0 comments Download
M nss/lib/ckfw/find.c View 8 chunks +210 lines, -227 lines 0 comments Download
M nss/lib/ckfw/hash.c View 9 chunks +141 lines, -161 lines 0 comments Download
M nss/lib/ckfw/instance.c View 34 chunks +754 lines, -826 lines 0 comments Download
M nss/lib/ckfw/mechanism.c View 32 chunks +600 lines, -680 lines 0 comments Download
M nss/lib/ckfw/mutex.c View 8 chunks +105 lines, -126 lines 0 comments Download
M nss/lib/ckfw/nssckfw.h View 28 chunks +87 lines, -156 lines 0 comments Download
M nss/lib/ckfw/nssckfwc.h View 3 chunks +373 lines, -507 lines 0 comments Download
M nss/lib/ckfw/nssckfwt.h View 2 chunks +1 line, -2 lines 0 comments Download
M nss/lib/ckfw/nssckmdt.h View 9 chunks +1740 lines, -1781 lines 0 comments Download
M nss/lib/ckfw/nssckt.h View 1 chunk +0 lines, -1 line 0 comments Download
M nss/lib/ckfw/object.c View 23 chunks +574 lines, -625 lines 0 comments Download
M nss/lib/ckfw/session.c View 33 chunks +1597 lines, -1680 lines 0 comments Download
M nss/lib/ckfw/sessobj.c View 17 chunks +639 lines, -702 lines 0 comments Download
M nss/lib/ckfw/slot.c View 19 chunks +361 lines, -403 lines 0 comments Download
M nss/lib/ckfw/token.c View 47 chunks +1020 lines, -1120 lines 0 comments Download
M nss/lib/ckfw/wrap.c View 58 chunks +4850 lines, -4972 lines 0 comments Download
M nss/lib/cryptohi/cryptohi.h View 19 chunks +53 lines, -57 lines 0 comments Download
M nss/lib/cryptohi/cryptoht.h View 1 chunk +0 lines, -1 line 0 comments Download
M nss/lib/cryptohi/dsautil.c View 9 chunks +71 lines, -67 lines 0 comments Download
M nss/lib/cryptohi/keyhi.h View 10 chunks +39 lines, -41 lines 0 comments Download
M nss/lib/cryptohi/keyi.h View 2 chunks +1 line, -2 lines 0 comments Download
M nss/lib/cryptohi/keythi.h View 9 chunks +33 lines, -36 lines 0 comments Download
M nss/lib/cryptohi/sechash.h View 1 chunk +22 lines, -22 lines 0 comments Download
M nss/lib/cryptohi/sechash.c View 9 chunks +236 lines, -207 lines 0 comments Download
M nss/lib/cryptohi/seckey.c View 41 chunks +976 lines, -962 lines 0 comments Download
M nss/lib/cryptohi/secsign.c View 13 chunks +231 lines, -218 lines 0 comments Download
M nss/lib/cryptohi/secvfy.c View 21 chunks +385 lines, -382 lines 0 comments Download
M nss/lib/dev/ckhelper.h View 2 chunks +70 lines, -79 lines 0 comments Download
M nss/lib/dev/ckhelper.c View 12 chunks +292 lines, -288 lines 0 comments Download
M nss/lib/dev/dev.h View 12 chunks +341 lines, -532 lines 0 comments Download
M nss/lib/dev/devm.h View 1 chunk +77 lines, -125 lines 0 comments Download
M nss/lib/dev/devslot.c View 6 chunks +84 lines, -94 lines 0 comments Download
M nss/lib/dev/devt.h View 4 chunks +40 lines, -49 lines 0 comments Download
M nss/lib/dev/devtm.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/dev/devtoken.c View 41 chunks +715 lines, -736 lines 0 comments Download
M nss/lib/dev/devutil.c View 18 chunks +492 lines, -501 lines 0 comments Download
M nss/lib/dev/nssdev.h View 1 chunk +4 lines, -8 lines 0 comments Download
M nss/lib/freebl/blapi.h View 1 chunk +24 lines, -27 lines 0 comments Download
M nss/lib/freebl/blapit.h View 1 chunk +1 line, -1 line 0 comments Download
A + nss/lib/freebl/chacha20.h View 1 chunk +10 lines, -6 lines 0 comments Download
A nss/lib/freebl/chacha20.c View 1 chunk +111 lines, -0 lines 0 comments Download
D nss/lib/freebl/chacha20/chacha20.h View 1 chunk +0 lines, -22 lines 0 comments Download
D nss/lib/freebl/chacha20/chacha20.c View 1 chunk +0 lines, -108 lines 0 comments Download
D nss/lib/freebl/chacha20/chacha20_vec.c View 1 chunk +0 lines, -281 lines 0 comments Download
A nss/lib/freebl/chacha20_vec.c View 1 chunk +278 lines, -0 lines 0 comments Download
M nss/lib/freebl/chacha20poly1305.c View 1 chunk +87 lines, -58 lines 0 comments Download
M nss/lib/freebl/ecl/ec_naf.c View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/freebl/ecl/ecp_256_32.c View 2 chunks +7 lines, -7 lines 0 comments Download
M nss/lib/freebl/ecl/ecp_aff.c View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/freebl/mpi/mpi.c View 2 chunks +7 lines, -3 lines 0 comments Download
M nss/lib/freebl/mpi/mpmontg.c View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/freebl/mpi/mpprime.c View 1 chunk +1 line, -1 line 0 comments Download
A + nss/lib/freebl/poly1305.h View 1 chunk +5 lines, -8 lines 0 comments Download
A + nss/lib/freebl/poly1305.c View 1 chunk +8 lines, -1 line 0 comments Download
A + nss/lib/freebl/poly1305-donna-x64-sse2-incremental-source.c View 0 chunks +-1 lines, --1 lines 0 comments Download
D nss/lib/freebl/poly1305/poly1305.h View 1 chunk +0 lines, -31 lines 0 comments Download
D nss/lib/freebl/poly1305/poly1305.c View 1 chunk +0 lines, -254 lines 0 comments Download
D nss/lib/freebl/poly1305/poly1305-donna-x64-sse2-incremental-source.c View 1 chunk +0 lines, -623 lines 0 comments Download
M nss/lib/freebl/rijndael.c View 3 chunks +5 lines, -1 line 0 comments Download
M nss/lib/freebl/rsa.c View 2 chunks +2 lines, -5 lines 0 comments Download
M nss/lib/freebl/unix_rand.c View 3 chunks +4 lines, -3 lines 0 comments Download
M nss/lib/libpkix/pkix/util/pkix_tools.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_httpcertstore.c View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_socket.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_lifecycle.c View 2 chunks +2 lines, -2 lines 0 comments Download
M nss/lib/nss/nss.h View 2 chunks +9 lines, -5 lines 0 comments Download
M nss/lib/nss/nssinit.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/nss/nssoptions.c View 3 chunks +33 lines, -1 line 0 comments Download
M nss/lib/pk11wrap/debug_module.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/pk11wrap/pk11akey.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/pk11wrap/pk11load.c View 4 chunks +4 lines, -4 lines 0 comments Download
M nss/lib/pk11wrap/pk11mech.c View 1 chunk +1 line, -0 lines 0 comments Download
M nss/lib/pk11wrap/pk11obj.c View 5 chunks +35 lines, -2 lines 0 comments Download
M nss/lib/pk11wrap/pk11pars.c View 8 chunks +522 lines, -12 lines 0 comments Download
M nss/lib/pk11wrap/pk11pbe.c View 2 chunks +21 lines, -8 lines 0 comments Download
M nss/lib/pk11wrap/pk11pub.h View 1 chunk +8 lines, -0 lines 0 comments Download
M nss/lib/pk11wrap/pk11util.c View 2 chunks +6 lines, -1 line 0 comments Download
M nss/lib/pk11wrap/secmodi.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/pkcs7/p7local.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/pkcs7/secmime.c View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/pki/certificate.c View 1 chunk +3 lines, -0 lines 0 comments Download
M nss/lib/pki/pki3hack.c View 1 chunk +3 lines, -1 line 0 comments Download
M nss/lib/softoken/fipstest.c View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/softoken/fipstokn.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/softoken/lgglue.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/softoken/lowkey.c View 5 chunks +5 lines, -5 lines 0 comments Download
M nss/lib/softoken/lowpbe.h View 1 chunk +2 lines, -1 line 0 comments Download
M nss/lib/softoken/lowpbe.c View 15 chunks +8 lines, -20 lines 0 comments Download
M nss/lib/softoken/pkcs11.c View 1 chunk +2 lines, -0 lines 0 comments Download
M nss/lib/softoken/pkcs11c.c View 14 chunks +101 lines, -81 lines 0 comments Download
M nss/lib/softoken/pkcs11i.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/softoken/sdb.c View 3 chunks +3 lines, -3 lines 0 comments Download
M nss/lib/softoken/sftkpars.c View 3 chunks +3 lines, -3 lines 0 comments Download
M nss/lib/softoken/sftkpwd.c View 2 chunks +3 lines, -2 lines 0 comments Download
M nss/lib/softoken/softkver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/softoken/softoken.h View 2 chunks +2 lines, -2 lines 0 comments Download
M nss/lib/ssl/sslerr.h View 2 chunks +207 lines, -193 lines 0 comments Download
M nss/lib/util/dersubr.c View 3 chunks +15 lines, -7 lines 0 comments Download
M nss/lib/util/dertime.c View 1 chunk +4 lines, -4 lines 0 comments Download
M nss/lib/util/nssutil.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/util/pkcs11n.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/util/pkcs11t.h View 1 chunk +9 lines, -3 lines 0 comments Download
M nss/lib/util/secasn1d.c View 5 chunks +40 lines, -11 lines 0 comments Download
M nss/lib/util/secoid.c View 8 chunks +81 lines, -5 lines 1 comment Download
M nss/lib/util/secoidt.h View 2 chunks +40 lines, -0 lines 0 comments Download
M nss/lib/util/secport.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/util/templates.c View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/util/utf8.c View 10 chunks +77 lines, -7 lines 0 comments Download
M nss/lib/util/utilmod.c View 5 chunks +5 lines, -5 lines 0 comments Download
M nss/lib/util/utilpars.h View 3 chunks +19 lines, -16 lines 0 comments Download
M nss/lib/util/utilpars.c View 20 chunks +37 lines, -32 lines 0 comments Download
M patches/nspr-attach-as-system-thread.patch View 1 chunk +5 lines, -5 lines 0 comments Download
M patches/nspr-static.patch View 3 chunks +11 lines, -11 lines 0 comments Download
D patches/nspr-unused-variable.patch View 1 chunk +0 lines, -12 lines 0 comments Download
D patches/nss-chacha20-poly1305.patch View 1 chunk +0 lines, -1891 lines 0 comments Download
M patches/nss-static.patch View 13 chunks +41 lines, -41 lines 0 comments Download
M patches/nss-urandom-abort.patch View 5 chunks +75 lines, -8 lines 0 comments Download
M scripts/nspr-checkout.sh View 1 chunk +1 line, -1 line 0 comments Download
M scripts/nss-checkout.sh View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
Ryan Sleevi
This is the corresponding DEPS roll (which has to happen first) David: FYI, since I ...
4 years, 8 months ago (2016-03-31 03:16:37 UTC) #2
svaldez
LGTM, nits probably not worth fixing since it just makes merging harder. Dropped the format-only ...
4 years, 8 months ago (2016-04-04 15:59:51 UTC) #4
Ryan Sleevi
4 years, 8 months ago (2016-04-05 03:32:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9014ff711cae72152f811056b333062664ed82ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698