Update NSPR to 4.12 and NSS to 3.23 on iOS

nss/lib/util/dersubr.c

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "secder.h"
 #include <limits.h>
 #include "secerr.h"
 
 int
 DER_LengthLength(PRUint32 len)
@@ skipping 161 matching lines @@
 }
 
 /*
 ** Convert a der encoded *signed* integer into a machine integral value.
 ** If an underflow/overflow occurs, sets error code and returns min/max.
 */
 long
 DER_GetInteger(const SECItem *it)
 {
     long ival = 0;
-    unsigned len = it->len;
+    PRBool negative = PR_FALSE;
+    unsigned int len = it->len;
+    unsigned int originalLength = len;
     unsigned char *cp = it->data;
     unsigned long overflow = 0x1ffUL << (((sizeof(ival) - 1) * 8) - 1);
-    unsigned long ofloinit;
+    unsigned long mask = 1;
 
     PORT_Assert(len);
     if (!len) {
         PORT_SetError(SEC_ERROR_INPUT_LEN);
         return 0;
     }
 
-    if (*cp & 0x80)
-        ival = -1L;
-    ofloinit = ival & overflow;
+    if (*cp & 0x80) {
+        negative = PR_TRUE;
+        overflow <<= 1;
+    }
 
     while (len) {
-        if ((ival & overflow) != ofloinit) {
+        if ((ival & overflow) != 0) {
             PORT_SetError(SEC_ERROR_BAD_DER);
-            if (ival < 0) {
+            if (negative) {
                 return LONG_MIN;
             }
             return LONG_MAX;
         }
         ival = ival << 8;
         ival |= *cp++;
         --len;
     }
+    if (negative && ival && (overflow & ival) == 0) {
+        mask <<=  ((originalLength  * 8) - 1);
+        ival &= ~mask;
+        ival -= mask;
+    }
     return ival;
 }
 
 /*
 ** Convert a der encoded *unsigned* integer into a machine integral value.
 ** If an overflow occurs, sets error code and returns max.
 */
 unsigned long
 DER_GetUInteger(SECItem *it)
 {
@@ skipping 18 matching lines @@
         if (ival & overflow) {
             PORT_SetError(SEC_ERROR_BAD_DER);
             return ULONG_MAX;
         }
         ival = ival << 8;
         ival |= *cp++;
         --len;
     }
     return ival;
 }