Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1843283002: [Offline pages] Updating the offline bolt icon to the new asset (Closed)

Created:
4 years, 8 months ago by fgorski
Modified:
4 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Updating the offline bolt icon to the new asset * Updating the icon to the new asset from go/icons, * PNG was crushed, * Updating the tinting of the icon on OIB, as asset has slightly different shade of gray. BUG=597664 Committed: https://crrev.com/dbbd1807f66e1b749fed6f92e9d5337c7efe0520 Cr-Commit-Position: refs/heads/master@{#385242}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updating the default color of the icon to 5a5a5a using convert #

Messages

Total messages: 11 (3 generated)
fgorski
PTAL
4 years, 8 months ago (2016-03-30 22:06:46 UTC) #2
newt (away)
These icons are actually used in other places (e.g. on the NTP). Could you recolor ...
4 years, 8 months ago (2016-03-30 22:23:01 UTC) #3
newt (away)
(You can recolor them using ImageMagick pretty easily)
4 years, 8 months ago (2016-03-30 22:23:38 UTC) #4
fgorski
On 2016/03/30 22:23:38, newt (no new reviews. mostly) wrote: > (You can recolor them using ...
4 years, 8 months ago (2016-04-05 17:49:01 UTC) #5
newt (away)
whew! no easy task, but it looks right :) lgtm
4 years, 8 months ago (2016-04-05 17:51:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843283002/20001
4 years, 8 months ago (2016-04-05 18:00:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 18:51:16 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:52:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dbbd1807f66e1b749fed6f92e9d5337c7efe0520
Cr-Commit-Position: refs/heads/master@{#385242}

Powered by Google App Engine
This is Rietveld 408576698