Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: chrome/android/java/res/layout/website_settings.xml

Issue 1843283002: [Offline pages] Updating the offline bolt icon to the new asset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/offline_bolt.png ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- 2 <!--
3 Copyright 2013 The Chromium Authors. All rights reserved. 3 Copyright 2013 The Chromium Authors. All rights reserved.
4 4
5 Use of this source code is governed by a BSD-style license that can be 5 Use of this source code is governed by a BSD-style license that can be
6 found in the LICENSE file. 6 found in the LICENSE file.
7 --> 7 -->
8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" 8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
9 android:layout_width="match_parent" 9 android:layout_width="match_parent"
10 android:layout_height="match_parent" 10 android:layout_height="match_parent"
11 android:paddingBottom="8dp" 11 android:paddingBottom="8dp"
12 android:background="#ffffff" 12 android:background="#ffffff"
13 android:orientation="vertical" > 13 android:orientation="vertical" >
14 14
15 <LinearLayout 15 <LinearLayout
16 android:layout_width="match_parent" 16 android:layout_width="match_parent"
17 android:layout_height="wrap_content" 17 android:layout_height="wrap_content"
18 android:orientation="vertical" 18 android:orientation="vertical"
19 android:paddingBottom="12dp" 19 android:paddingBottom="12dp"
20 android:paddingEnd="@dimen/website_settings_popup_padding_sides" 20 android:paddingEnd="@dimen/website_settings_popup_padding_sides"
21 android:paddingStart="@dimen/website_settings_popup_padding_sides" > 21 android:paddingStart="@dimen/website_settings_popup_padding_sides" >
22 22
23 <LinearLayout 23 <LinearLayout
24 android:layout_width="match_parent" 24 android:layout_width="match_parent"
25 android:layout_height="wrap_content" 25 android:layout_height="wrap_content"
26 android:orientation="horizontal" 26 android:orientation="horizontal"
27 android:paddingTop="16dp" > 27 android:paddingTop="16dp" >
28 28
29 <ImageView android:id="@+id/offline_icon" 29 <org.chromium.chrome.browser.widget.TintedImageView
30 xmlns:android="http://schemas.android.com/apk/res/android"
newt (away) 2016/03/30 22:23:01 Don't need xmlns:android. Put xmlns:chrome in the
31 xmlns:chrome="http://schemas.android.com/apk/res-auto"
32 android:id="@+id/offline_icon"
30 style="@style/LocationBarButton" 33 style="@style/LocationBarButton"
31 android:layout_width="wrap_content" 34 android:layout_width="wrap_content"
32 android:layout_height="wrap_content" 35 android:layout_height="wrap_content"
33 android:layout_gravity="start|top" 36 android:layout_gravity="start|top"
34 android:paddingEnd="8dp" 37 android:paddingEnd="8dp"
35 android:src="@drawable/offline_bolt" 38 android:src="@drawable/offline_bolt"
36 android:visibility="gone" 39 android:visibility="gone"
37 android:contentDescription="@string/page_info_offline_icon" /> 40 android:contentDescription="@string/page_info_offline_icon"
41 chrome:tint="@color/dark_mode_tint" />
38 42
39 <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPop up$ElidedUrlTextView" 43 <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPop up$ElidedUrlTextView"
40 android:id="@+id/website_settings_url" 44 android:id="@+id/website_settings_url"
41 android:layout_width="match_parent" 45 android:layout_width="match_parent"
42 android:layout_height="wrap_content" 46 android:layout_height="wrap_content"
43 android:ellipsize="end" 47 android:ellipsize="end"
44 android:lineSpacingExtra="6dp" 48 android:lineSpacingExtra="6dp"
45 android:textAlignment="viewStart" 49 android:textAlignment="viewStart"
46 android:textColor="@color/url_emphasis_default_text" 50 android:textColor="@color/url_emphasis_default_text"
47 android:textSize="16sp"/> 51 android:textSize="16sp"/>
(...skipping 26 matching lines...) Expand all
74 android:layout_gravity="end" 78 android:layout_gravity="end"
75 android:layout_marginEnd="@dimen/website_settings_popup_padding_sides" 79 android:layout_marginEnd="@dimen/website_settings_popup_padding_sides"
76 android:layout_marginStart="@dimen/website_settings_popup_padding_sides" 80 android:layout_marginStart="@dimen/website_settings_popup_padding_sides"
77 android:layout_marginTop="8dp" 81 android:layout_marginTop="8dp"
78 android:paddingEnd="@dimen/website_settings_popup_button_padding_sides" 82 android:paddingEnd="@dimen/website_settings_popup_button_padding_sides"
79 android:paddingStart="@dimen/website_settings_popup_button_padding_sides " 83 android:paddingStart="@dimen/website_settings_popup_button_padding_sides "
80 android:text="@string/page_info_site_settings_button" 84 android:text="@string/page_info_site_settings_button"
81 android:textColor="@color/light_active_color" 85 android:textColor="@color/light_active_color"
82 style="@style/ButtonCompatBorderless" /> 86 style="@style/ButtonCompatBorderless" />
83 </LinearLayout> 87 </LinearLayout>
OLDNEW
« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/offline_bolt.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698