PPC: [turbofan] Frame elision for code stubs.

PPC: [turbofan] Frame elision for code stubs.

Port 53d51c52f3754fe0e7decacba4277e58cf9fb5a4

Includes fixes required for embedded constant pools.

Original commit message:
    Removed Frame::needs_frame and the function-wide logic using it in
    favor of FrameAccessState::has_frame, which can be set on a more
    granular level, and driving it block by block.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, rmcilroy@chromium.org
BUG=v8:4533
LOG=N

Committed: https://crrev.com/9e1f2c5ee20d0e2c3c2a7a6f1a247d60e02d71c9
Cr-Commit-Position: refs/heads/master@{#35166}

[MTBrandyberry, 2016-03-30 21:42:59]

PTAL

[MTBrandyberry, 2016-03-30 21:43:04]

The CQ bit was checked by mbrandy@us.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 21:43:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843273002/1

[JoranSiu, 2016-03-30 21:54:56]

On 2016/03/30 21:43:09, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1843273002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1843273002/1

lgtm

[commit-bot: I haz the power, 2016-03-30 22:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:07:03]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2016-03-30 22:39:25]

https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):

https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator...
src/compiler/code-generator.cc:164: Instruction* instr =
code()->InstructionAt(i);
To avoid code duplication, could you please factor the for loop in a
AssembleBlock(block)?

https://codereview.chromium.org/1843273002/diff/1/src/compiler/ppc/code-gener...
File src/compiler/ppc/code-generator-ppc.cc (left):

https://codereview.chromium.org/1843273002/diff/1/src/compiler/ppc/code-gener...
src/compiler/ppc/code-generator-ppc.cc:1805: __ Drop(pop_count);
What happened to the pop_count?

[MTBrandyberry, 2016-03-30 22:57:47]

https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):

https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator...
src/compiler/code-generator.cc:164: Instruction* instr =
code()->InstructionAt(i);
On 2016/03/30 22:39:24, Mircea Trofin wrote:
> To avoid code duplication, could you please factor the for loop in a
> AssembleBlock(block)?

Will do.

https://codereview.chromium.org/1843273002/diff/1/src/compiler/ppc/code-gener...
File src/compiler/ppc/code-generator-ppc.cc (left):

https://codereview.chromium.org/1843273002/diff/1/src/compiler/ppc/code-gener...
src/compiler/ppc/code-generator-ppc.cc:1805: __ Drop(pop_count);
On 2016/03/30 22:39:24, Mircea Trofin wrote:
> What happened to the pop_count?

Since we can no longer can pass it via AssembleDeconstructFrame to Leaveframe,
the adjustment is done in all cases by Ret below.

[MTBrandyberry, 2016-03-31 02:06:35]

https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):

https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator...
src/compiler/code-generator.cc:164: Instruction* instr =
code()->InstructionAt(i);
On 2016/03/30 22:39:24, Mircea Trofin wrote:
> To avoid code duplication, could you please factor the for loop in a
> AssembleBlock(block)?

Done.

[Mircea Trofin, 2016-03-31 02:16:56]

On 2016/03/31 02:06:35, MTBrandyberry wrote:
>
https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator.cc
> File src/compiler/code-generator.cc (right):
> 
>
https://codereview.chromium.org/1843273002/diff/1/src/compiler/code-generator...
> src/compiler/code-generator.cc:164: Instruction* instr =
> code()->InstructionAt(i);
> On 2016/03/30 22:39:24, Mircea Trofin wrote:
> > To avoid code duplication, could you please factor the for loop in a
> > AssembleBlock(block)?
> 
> Done.

LGTM. Thanks!

[john.yan, 2016-03-31 03:44:30]

lgtm

[MTBrandyberry, 2016-03-31 13:37:49]

The CQ bit was checked by mbrandy@us.ibm.com

[MTBrandyberry, 2016-03-31 13:37:49]

The patchset sent to the CQ was uploaded after l-g-t-m from joransiu@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/1843273002/#ps20001
(title: "Add AssembleBlock")

[commit-bot: I haz the power, 2016-03-31 13:37:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843273002/20001

[commit-bot: I haz the power, 2016-03-31 13:59:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 14:00:32]

Description was changed from

==========
PPC: [turbofan] Frame elision for code stubs.

Port 53d51c52f3754fe0e7decacba4277e58cf9fb5a4

Includes fixes required for embedded constant pools.

Original commit message:
    Removed Frame::needs_frame and the function-wide logic using it in
    favor of FrameAccessState::has_frame, which can be set on a more
    granular level, and driving it block by block.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, rmcilroy@chromium.org
BUG=v8:4533
LOG=N
==========

to

==========
PPC: [turbofan] Frame elision for code stubs.

Port 53d51c52f3754fe0e7decacba4277e58cf9fb5a4

Includes fixes required for embedded constant pools.

Original commit message:
    Removed Frame::needs_frame and the function-wide logic using it in
    favor of FrameAccessState::has_frame, which can be set on a more
    granular level, and driving it block by block.

R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, rmcilroy@chromium.org
BUG=v8:4533
LOG=N

Committed: https://crrev.com/9e1f2c5ee20d0e2c3c2a7a6f1a247d60e02d71c9
Cr-Commit-Position: refs/heads/master@{#35166}
==========

[commit-bot: I haz the power, 2016-03-31 14:00:33]

Patchset 2 (id:??) landed as
https://crrev.com/9e1f2c5ee20d0e2c3c2a7a6f1a247d60e02d71c9
Cr-Commit-Position: refs/heads/master@{#35166}