PPC: [turbofan] Frame elision for code stubs.

src/compiler/code-generator.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 
 #include "src/address-map.h"
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/pipeline.h"
@@ skipping 135 matching lines @@
         AssemblePrologue();
         // We need to setup the root register after we assemble the prologue, to
         // avoid clobbering callee saved registers in case of C linkage and
         // using the roots.
         // TODO(mtrofin): investigate how we can avoid doing this repeatedly.
         if (linkage()->GetIncomingDescriptor()->InitializeRootRegister()) {
           masm()->InitializeRootRegister();
         }
       }
 
-      for (int i = block->code_start(); i < block->code_end(); ++i) {
-        Instruction* instr = code()->InstructionAt(i);
-        AssembleInstruction(instr, block);
+      if (FLAG_enable_embedded_constant_pool && !block->needs_frame()) {
+        ConstantPoolUnavailableScope constant_pool_unavailable(masm());
+        for (int i = block->code_start(); i < block->code_end(); ++i) {
+          Instruction* instr = code()->InstructionAt(i);
+          AssembleInstruction(instr, block);
+        }
+      } else {
+        for (int i = block->code_start(); i < block->code_end(); ++i) {
+          Instruction* instr = code()->InstructionAt(i);

[Mircea Trofin, 2016/03/30 22:39:24]

To avoid code duplication, could you please factor the for loop in a
AssembleBlock(block)?

[MTBrandyberry, 2016/03/30 22:57:47]

Will do.

[MTBrandyberry, 2016/03/31 02:06:35]

Done.

+          AssembleInstruction(instr, block);
+        }
       }
     }
   }
 
   // Assemble all out-of-line code.
   if (ools_) {
     masm()->RecordComment("-- Out of line code --");
     for (OutOfLineCode* ool = ools_; ool; ool = ool->next()) {
       masm()->bind(ool->entry());
       ool->Generate();
@@ skipping 620 matching lines @@
     : frame_(gen->frame()), masm_(gen->masm()), next_(gen->ools_) {
   gen->ools_ = this;
 }
 
 
 OutOfLineCode::~OutOfLineCode() {}
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8