Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1843233002: media: AVDA now always notifies GVD of consumed bitstream buffers (Closed)

Created:
4 years, 8 months ago by watk
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 Review URL: https://codereview.chromium.org/1831323002 Cr-Commit-Position: refs/heads/master@{#383836} (cherry picked from commit c3aaff8dbedaf7ce7fdfeb6fde7031486e485408) Committed: https://chromium.googlesource.com/chromium/src/+/bd2bede866bee839251d2e7659022e885b54d928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M content/common/gpu/media/android_video_decode_accelerator.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
watk
4 years, 8 months ago (2016-03-30 20:36:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd2bede866bee839251d2e7659022e885b54d928.

Powered by Google App Engine
This is Rietveld 408576698