Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1831323002:
media: AVDA now always notifies the end of consumed bitstream buffers (Closed)
|
Created:
4 years, 9 months ago by watk Modified:
4 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: AVDA now always notifies GVD of consumed bitstream buffers
In AVDA::QueueInput it was possible that a pending bitstream buffer was
popped from the queue but then a failure caused it to return without
NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was
propogated to GVD, GVD and AVDA became out of sync.
Now the bitstream buffer notification is done regardless of whether
an error occurred.
BUG=598058
Committed: https://crrev.com/c3aaff8dbedaf7ce7fdfeb6fde7031486e485408
Cr-Commit-Position: refs/heads/master@{#383836}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 19 (9 generated)
Description was changed from ========== media: AVDA now always notifies the end of consumed bitstream buffers BUG= ========== to ========== media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 ==========
watk@chromium.org changed reviewers: + liberato@chromium.org
Description was changed from ========== media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 ========== to ========== media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 ==========
Hmm, I forgot to send this apparently.
lgtm https://codereview.chromium.org/1831323002/diff/1/content/common/gpu/media/an... File content/common/gpu/media/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/1831323002/diff/1/content/common/gpu/media/an... content/common/gpu/media/android_video_decode_accelerator.cc:550: bitstreams_notified_in_advance_.push_back(bitstream_buffer.id()); i was going to say that |bitstreams_notified_in_advance_| should only be updated in the non-error case. then, i remembered that it should just be removed entirely. :)
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
liberato@chromium.org changed reviewers: + dalecurtis@chromium.org
On 2016/03/29 20:47:49, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) oh, commit-bot, we still like you! +dale
lgtm
Whoops, reminds me I need to update OWNERS files :)
The CQ bit was checked by watk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831323002/1
Message was sent while issue was closed.
Description was changed from ========== media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 ========== to ========== media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 ========== to ========== media: AVDA now always notifies GVD of consumed bitstream buffers In AVDA::QueueInput it was possible that a pending bitstream buffer was popped from the queue but then a failure caused it to return without NotifyEndOfBitstreamBuffer. If AVDA was Reset before the error was propogated to GVD, GVD and AVDA became out of sync. Now the bitstream buffer notification is done regardless of whether an error occurred. BUG=598058 Committed: https://crrev.com/c3aaff8dbedaf7ce7fdfeb6fde7031486e485408 Cr-Commit-Position: refs/heads/master@{#383836} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c3aaff8dbedaf7ce7fdfeb6fde7031486e485408 Cr-Commit-Position: refs/heads/master@{#383836} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
