Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1843183002: [Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py (Closed)

Created:
4 years, 8 months ago by pauljensen
Modified:
4 years, 8 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py Without this many Cronet tests will fail. BUG=598891 Committed: https://crrev.com/4208479e0d831431c74fb2a61599d35738b9f0ec Cr-Commit-Position: refs/heads/master@{#385448}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/cronet/tools/cr_cronet.py View 1 1 chunk +3 lines, -1 line 3 comments Download

Messages

Total messages: 12 (5 generated)
pauljensen
Helen, PTAL.
4 years, 8 months ago (2016-04-06 12:04:28 UTC) #3
xunjieli
https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools/cr_cronet.py File components/cronet/tools/cr_cronet.py (right): https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools/cr_cronet.py#newcode28 components/cronet/tools/cr_cronet.py:28: ' --apk=CronetTest.apk') or \ I don't really know Python. ...
4 years, 8 months ago (2016-04-06 13:10:04 UTC) #4
pauljensen
https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools/cr_cronet.py File components/cronet/tools/cr_cronet.py (right): https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools/cr_cronet.py#newcode28 components/cronet/tools/cr_cronet.py:28: ' --apk=CronetTest.apk') or \ On 2016/04/06 13:10:04, xunjieli wrote: ...
4 years, 8 months ago (2016-04-06 13:12:53 UTC) #5
xunjieli
Thanks! lgtm https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools/cr_cronet.py File components/cronet/tools/cr_cronet.py (right): https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools/cr_cronet.py#newcode28 components/cronet/tools/cr_cronet.py:28: ' --apk=CronetTest.apk') or \ On 2016/04/06 13:12:53, ...
4 years, 8 months ago (2016-04-06 13:14:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843183002/20001
4 years, 8 months ago (2016-04-06 13:15:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 13:43:39 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 13:44:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4208479e0d831431c74fb2a61599d35738b9f0ec
Cr-Commit-Position: refs/heads/master@{#385448}

Powered by Google App Engine
This is Rietveld 408576698