[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

Without this many Cronet tests will fail.

BUG=598891
Committed: https://crrev.com/4208479e0d831431c74fb2a61599d35738b9f0ec
Cr-Commit-Position: refs/heads/master@{#385448}

[pauljensen, 2016-04-06 12:03:27]

Description was changed from

==========
Don't forget EmbeddedTestServer apk when building and testing with cr_cronet.py

Without this many Cronet tests will fail.
==========

to

==========
[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

Without this many Cronet tests will fail.

BUG=598891
==========

[pauljensen, 2016-04-06 12:03:28]

pauljensen@chromium.org changed reviewers:
+ xunjieli@chromium.org

[pauljensen, 2016-04-06 12:04:28]

Helen, PTAL.

[xunjieli, 2016-04-06 13:10:04]

https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools...
components/cronet/tools/cr_cronet.py:28: ' --apk=CronetTest.apk') or \
I don't really know Python. Should this be "and" instead of "or' ? Does Python
evaluate both even though first run returns true?

[pauljensen, 2016-04-06 13:12:53]

https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools...
components/cronet/tools/cr_cronet.py:28: ' --apk=CronetTest.apk') or \
On 2016/04/06 13:10:04, xunjieli wrote:
> I don't really know Python. Should this be "and" instead of "or' ? Does Python
> evaluate both even though first run returns true?

run() returns the return code, so 0 is success, so we want to stop when either
returns non-zero.  "or" in Python is short-circuting, so if the first one
returns non-zero it will not run the second one, which is the desire behavior.

http://stackoverflow.com/questions/2580136/does-python-support-short-circuiting

[xunjieli, 2016-04-06 13:14:37]

Thanks! lgtm

https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/1843183002/diff/20001/components/cronet/tools...
components/cronet/tools/cr_cronet.py:28: ' --apk=CronetTest.apk') or \
On 2016/04/06 13:12:53, pauljensen wrote:
> On 2016/04/06 13:10:04, xunjieli wrote:
> > I don't really know Python. Should this be "and" instead of "or' ? Does
Python
> > evaluate both even though first run returns true?
> 
> run() returns the return code, so 0 is success, so we want to stop when either
> returns non-zero.  "or" in Python is short-circuting, so if the first one
> returns non-zero it will not run the second one, which is the desire behavior.
> 
>
http://stackoverflow.com/questions/2580136/does-python-support-short-circuiting

Ah, that makes sense. Thanks.

[pauljensen, 2016-04-06 13:15:29]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-04-06 13:15:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843183002/20001

[commit-bot: I haz the power, 2016-04-06 13:43:38]

Description was changed from

==========
[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

Without this many Cronet tests will fail.

BUG=598891
==========

to

==========
[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

Without this many Cronet tests will fail.

BUG=598891
==========

[commit-bot: I haz the power, 2016-04-06 13:43:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 13:44:55]

Description was changed from

==========
[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

Without this many Cronet tests will fail.

BUG=598891
==========

to

==========
[Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py

Without this many Cronet tests will fail.

BUG=598891

Committed: https://crrev.com/4208479e0d831431c74fb2a61599d35738b9f0ec
Cr-Commit-Position: refs/heads/master@{#385448}
==========

[commit-bot: I haz the power, 2016-04-06 13:44:56]

Patchset 2 (id:??) landed as
https://crrev.com/4208479e0d831431c74fb2a61599d35738b9f0ec
Cr-Commit-Position: refs/heads/master@{#385448}