Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 1843183002: [Cronet] Don't forget EmbeddedTestServer apk when testing with cr_cronet.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/cr_cronet.py
diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py
index bb19362d647bd6f88ecd2da5c732969684e55ec0..f447e94ca96ea192df7f637daeb027f14a1bb625 100755
--- a/components/cronet/tools/cr_cronet.py
+++ b/components/cronet/tools/cr_cronet.py
@@ -25,7 +25,9 @@ def build(out_dir, extra_options=''):
def install(release_arg):
return run('build/android/adb_install_apk.py ' + release_arg + \
- ' --apk=CronetTest.apk')
+ ' --apk=CronetTest.apk') or \
xunjieli 2016/04/06 13:10:04 I don't really know Python. Should this be "and" i
pauljensen 2016/04/06 13:12:53 run() returns the return code, so 0 is success, so
xunjieli 2016/04/06 13:14:37 Ah, that makes sense. Thanks.
+ run('build/android/adb_install_apk.py ' + release_arg + \
+ ' --apk=ChromiumNetTestSupport.apk')
def test(release_arg, extra_options):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698