Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: Source/core/css/CSSProperty.h

Issue 184313004: Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSProperty.h
diff --git a/Source/core/css/CSSProperty.h b/Source/core/css/CSSProperty.h
index 00244680aa4e815d4d3812535ace413a0bed123c..4f6a40c61737c68b0365542dce3d9bf0fa7e6ac0 100644
--- a/Source/core/css/CSSProperty.h
+++ b/Source/core/css/CSSProperty.h
@@ -53,6 +53,7 @@ struct StylePropertyMetadata {
};
class CSSProperty {
+ ALLOW_ONLY_INLINE_ALLOCATION();
haraken 2014/03/04 15:34:25 Just to confirm: Now we don't need to manually add
wibling-chromium 2014/03/05 08:16:52 Right. It should just work.
public:
CSSProperty(CSSPropertyID propertyID, PassRefPtrWillBeRawPtr<CSSValue> value, bool important = false, bool isSetFromShorthand = false, int indexInShorthandsVector = 0, bool implicit = false)
: m_metadata(propertyID, isSetFromShorthand, indexInShorthandsVector, important, implicit, isInheritedProperty(propertyID))
@@ -81,9 +82,11 @@ public:
const StylePropertyMetadata& metadata() const { return m_metadata; }
+ void trace(Visitor* visitor) { visitor->trace(m_value); }
+
private:
StylePropertyMetadata m_metadata;
- RefPtr<CSSValue> m_value;
+ RefPtrWillBeMember<CSSValue> m_value;
};
inline CSSPropertyID prefixingVariantForPropertyId(CSSPropertyID propId)

Powered by Google App Engine
This is Rietveld 408576698