Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue.

Source/core/css/CSSProperty.h

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 35 matching lines @@
 
     uint16_t m_propertyID : 10;
     uint16_t m_isSetFromShorthand : 1;
     uint16_t m_indexInShorthandsVector : 2; // If this property was set as part of an ambiguous shorthand, gives the index in the shorthands vector.
     uint16_t m_important : 1;
     uint16_t m_implicit : 1; // Whether or not the property was set implicitly as the result of a shorthand.
     uint16_t m_inherited : 1;
 };
 
 class CSSProperty {
+    ALLOW_ONLY_INLINE_ALLOCATION();

[haraken, 2014/03/04 15:34:25]

Just to confirm: Now we don't need to manually add the NeedsTracing trait for
CSSProperty, right?

[wibling-chromium, 2014/03/05 08:16:52]

Right. It should just work.

 public:
     CSSProperty(CSSPropertyID propertyID, PassRefPtrWillBeRawPtr<CSSValue> value, bool important = false, bool isSetFromShorthand = false, int indexInShorthandsVector = 0, bool implicit = false)
         : m_metadata(propertyID, isSetFromShorthand, indexInShorthandsVector, important, implicit, isInheritedProperty(propertyID))
         , m_value(value)
     {
     }
 
     // FIXME: Remove this.
     CSSProperty(StylePropertyMetadata metadata, CSSValue* value)
         : m_metadata(metadata)
         , m_value(value)
     {
     }
 
     CSSPropertyID id() const { return static_cast<CSSPropertyID>(m_metadata.m_propertyID); }
     bool isSetFromShorthand() const { return m_metadata.m_isSetFromShorthand; };
     CSSPropertyID shorthandID() const { return m_metadata.shorthandID(); };
     bool isImportant() const { return m_metadata.m_important; }
 
     CSSValue* value() const { return m_value.get(); }
 
     void wrapValueInCommaSeparatedList();
 
     static CSSPropertyID resolveDirectionAwareProperty(CSSPropertyID, TextDirection, WritingMode);
     static bool isInheritedProperty(CSSPropertyID);
 
     const StylePropertyMetadata& metadata() const { return m_metadata; }
 
+    void trace(Visitor* visitor) { visitor->trace(m_value); }
+
 private:
     StylePropertyMetadata m_metadata;
-    RefPtr<CSSValue> m_value;
+    RefPtrWillBeMember<CSSValue> m_value;
 };
 
 inline CSSPropertyID prefixingVariantForPropertyId(CSSPropertyID propId)
 {
     if (!RuntimeEnabledFeatures::cssAnimationUnprefixedEnabled() && (propId >= CSSPropertyWebkitAnimation && propId <= CSSPropertyAnimationTimingFunction))
         return propId;
 
     CSSPropertyID propertyId = CSSPropertyInvalid;
     switch (propId) {
     case CSSPropertyAnimation:
@@ skipping 86 matching lines @@
     }
     ASSERT(propertyId != CSSPropertyInvalid);
     return propertyId;
 }
 
 } // namespace WebCore
 
 namespace WTF {
 template <> struct VectorTraits<WebCore::CSSProperty> : VectorTraitsBase<WebCore::CSSProperty> {
     static const bool canInitializeWithMemset = true;
     static const bool canMoveWithMemcpy = true;

[haraken, 2014/03/04 15:34:25]

Just to confirm: Are you sure that this trait is still correct in the oilpan
world?

[wibling-chromium, 2014/03/05 08:16:52]

I believe so. I will get Erik to confirm.

[Erik Corry, 2014/03/05 08:41:05]

The trait should still work.

You can't have it set to true for things that are linked together like
Persistent handles, because they would break when memcpy'ed.  Members and
RefPtrs can be memcpy'ed.

 };
 }
 
 #endif // CSSProperty_h