Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1842933003: Disable LogChannelIDAndCookieStores NOTREACHED. (Closed)

Created:
4 years, 8 months ago by bzanotti
Modified:
4 years, 8 months ago
Reviewers:
nharper, sdefresne, mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable LogChannelIDAndCookieStores NOTREACHED. The NOTREACHED is actually reached on iOS. Disable it for now. Also implement on iOS the ChannelIDService tracking logic as it was not done in http://crrev.com/1818603002. BUG=599049 Committed: https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7 Cr-Commit-Position: refs/heads/master@{#384001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
bzanotti
Please take a look.
4 years, 8 months ago (2016-03-30 09:58:08 UTC) #2
mmenke
On 2016/03/30 09:58:08, bzanotti wrote: > Please take a look. LGTM, though we'll certainly want ...
4 years, 8 months ago (2016-03-30 14:55:18 UTC) #3
mmenke
[+nharper]
4 years, 8 months ago (2016-03-30 14:55:57 UTC) #5
bzanotti
On 2016/03/30 14:55:18, mmenke wrote: > On 2016/03/30 09:58:08, bzanotti wrote: > > Please take ...
4 years, 8 months ago (2016-03-30 14:56:56 UTC) #6
bzanotti
Sylvain: Please do an OWNERS review of ios/chrome/browser/browser_state/.
4 years, 8 months ago (2016-03-30 15:05:17 UTC) #8
sdefresne
lgtm
4 years, 8 months ago (2016-03-30 15:10:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842933003/1
4 years, 8 months ago (2016-03-30 15:38:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 16:43:52 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:46:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7
Cr-Commit-Position: refs/heads/master@{#384001}

Powered by Google App Engine
This is Rietveld 408576698