Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Side by Side Diff: net/url_request/url_request_http_job.cc

Issue 1842933003: Disable LogChannelIDAndCookieStores NOTREACHED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/ios_chrome_io_thread.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_http_job.h" 5 #include "net/url_request/url_request_http_job.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 NOTREACHED(); 133 NOTREACHED();
134 ephemerality = EPHEMERAL_MISMATCH; 134 ephemerality = EPHEMERAL_MISMATCH;
135 } 135 }
136 } else if (context->has_known_mismatched_cookie_store()) { 136 } else if (context->has_known_mismatched_cookie_store()) {
137 ephemerality = KNOWN_MISMATCH; 137 ephemerality = KNOWN_MISMATCH;
138 } else { 138 } else {
139 NOTREACHED(); 139 NOTREACHED();
140 ephemerality = CID_EPHEMERAL_COOKIE_PERSISTENT; 140 ephemerality = CID_EPHEMERAL_COOKIE_PERSISTENT;
141 } 141 }
142 } else if (cookie_store->IsEphemeral()) { 142 } else if (cookie_store->IsEphemeral()) {
143 NOTREACHED(); 143 // TODO(crbug.com/599049): Add NOTREACHED once this case doesn't happen on
144 // iOS anymore.
144 ephemerality = CID_PERSISTENT_COOKIE_EPHEMERAL; 145 ephemerality = CID_PERSISTENT_COOKIE_EPHEMERAL;
145 } else if (cookie_store->GetChannelIDServiceID() == -1) { 146 } else if (cookie_store->GetChannelIDServiceID() == -1) {
146 ephemerality = PERSISTENT_UNKNOWN; 147 ephemerality = PERSISTENT_UNKNOWN;
147 } else if (cookie_store->GetChannelIDServiceID() == 148 } else if (cookie_store->GetChannelIDServiceID() ==
148 params->channel_id_service->GetUniqueID()) { 149 params->channel_id_service->GetUniqueID()) {
149 ephemerality = PERSISTENT_MATCH; 150 ephemerality = PERSISTENT_MATCH;
150 } else { 151 } else {
151 NOTREACHED(); 152 NOTREACHED();
152 ephemerality = PERSISTENT_MISMATCH; 153 ephemerality = PERSISTENT_MISMATCH;
153 } 154 }
(...skipping 1503 matching lines...) Expand 10 before | Expand all | Expand 10 after
1657 return override_response_headers_.get() ? 1658 return override_response_headers_.get() ?
1658 override_response_headers_.get() : 1659 override_response_headers_.get() :
1659 transaction_->GetResponseInfo()->headers.get(); 1660 transaction_->GetResponseInfo()->headers.get();
1660 } 1661 }
1661 1662
1662 void URLRequestHttpJob::NotifyURLRequestDestroyed() { 1663 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
1663 awaiting_callback_ = false; 1664 awaiting_callback_ = false;
1664 } 1665 }
1665 1666
1666 } // namespace net 1667 } // namespace net
OLDNEW
« no previous file with comments | « ios/chrome/browser/ios_chrome_io_thread.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698