Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 184283003: DevTools: support configurable category filter for trace events callback (Closed)

Created:
6 years, 9 months ago by caseq
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

DevTools: support configurable category filter for trace events callback DevTools callback is currently invoked for all callbacks which is a waste of time as we only need a few. This will become more critical once we start processing ConvertableToTraceFormat arguments. We'd also like to select categories based on the different options enabled, so let's move the filter to the DevTools back-end. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254143

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M content/renderer/devtools/devtools_agent.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 1 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
blink counterpart: https://codereview.chromium.org/184043004/
6 years, 9 months ago (2014-02-28 08:46:46 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/184283003/diff/1/content/renderer/devtools/devtools_agent.h File content/renderer/devtools/devtools_agent.h (right): https://codereview.chromium.org/184283003/diff/1/content/renderer/devtools/devtools_agent.h#newcode66 content/renderer/devtools/devtools_agent.h:66: virtual void unsetTraceEventCallback(); reset?
6 years, 9 months ago (2014-02-28 09:23:01 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-02-28 09:47:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/184283003/20001
6 years, 9 months ago (2014-02-28 09:48:08 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 16:09:48 UTC) #5
Message was sent while issue was closed.
Change committed as 254143

Powered by Google App Engine
This is Rietveld 408576698