Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2343)

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 184283003: DevTools: support configurable category filter for trace events callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments addressed Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/devtools/devtools_agent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/devtools_agent.cc
diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc
index a2415441e25a2263e1476a104a1311d5200a1924..45c6c7c58b84182125ea164473aa04ecc0e844e2 100644
--- a/content/renderer/devtools/devtools_agent.cc
+++ b/content/renderer/devtools/devtools_agent.cc
@@ -140,19 +140,31 @@ void DevToolsAgent::clearBrowserCookies() {
Send(new DevToolsHostMsg_ClearBrowserCookies(routing_id()));
}
-void DevToolsAgent::setTraceEventCallback(TraceEventCallback cb) {
+void DevToolsAgent::resetTraceEventCallback()
+{
+ TraceLog::GetInstance()->SetEventCallbackDisabled();
+ base::subtle::NoBarrier_Store(&event_callback_, 0);
+}
+
+void DevToolsAgent::setTraceEventCallback(const WebString& category_filter,
+ TraceEventCallback cb) {
TraceLog* trace_log = TraceLog::GetInstance();
base::subtle::NoBarrier_Store(&event_callback_,
reinterpret_cast<base::subtle::AtomicWord>(cb));
if (!!cb) {
trace_log->SetEventCallbackEnabled(base::debug::CategoryFilter(
- base::debug::CategoryFilter::kDefaultCategoryFilterString),
- TraceEventCallbackWrapper);
+ category_filter.utf8()), TraceEventCallbackWrapper);
} else {
trace_log->SetEventCallbackDisabled();
}
}
+void DevToolsAgent::setTraceEventCallback(TraceEventCallback cb) {
+ WebString category_filter = WebString::fromUTF8(
+ base::debug::CategoryFilter::kDefaultCategoryFilterString);
+ setTraceEventCallback(category_filter, cb);
+}
+
// static
void DevToolsAgent::TraceEventCallbackWrapper(
base::TimeTicks timestamp,
« no previous file with comments | « content/renderer/devtools/devtools_agent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698