Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 1842763003: Revert of Remove secondary player from Media Sessions (Closed)

Created:
4 years, 8 months ago by aberent
Modified:
4 years, 8 months ago
Reviewers:
boliu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Revert of Remove secondary player from Media Sessions (patchset #1 id:1 of https://codereview.chromium.org/1836093003/ ) Reason for revert: Didn't build on M50. Original issue's description: > Remove secondary player from Media Sessions > > When we switch Android media players, for cast, we no longer want audio > focus changes associated with old player to take effect. To handle this > remove the old player from the Media Sessions. > > The new player is responsible for adding itself to the Media Sessions if > it needs to. The remote player doesn't need to, and, after stopping casting > the local player will do so when the user presses play. > > BUG=595373 > > Review URL: https://codereview.chromium.org/1823983002 > > Cr-Commit-Position: refs/heads/master@{#382613} > (cherry picked from commit 4bee90cc8b21594a3fc5c4055887886aa2009865) > > Committed: https://chromium.googlesource.com/chromium/src/+/3ad63a558b2fbe889d02eeffe2f664955bfc9f07 TBR=boliu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/browser/media/android/browser_media_player_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/android/media_web_contents_observer_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/android/media_web_contents_observer_android.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
aberent
Created Revert of Remove secondary player from Media Sessions
4 years, 8 months ago (2016-03-29 17:45:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842763003/1
4 years, 8 months ago (2016-03-29 17:46:12 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:47:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698