Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1842763002: [api] Add a switch that controls if ES2015 tail call elimination feature is enabled or not. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@tco-dynamic
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add a switch that controls if ES2015 tail call elimination feature is enabled or not. BUG=v8:4698 LOG=N TBR=rossberg@chromium.org Committed: https://crrev.com/037f7f62159fe673e29d12419033ddc53ac5002e Cr-Commit-Position: refs/heads/master@{#35132}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments updated #

Patch Set 3 : Fixed Ignition plus TurboFan combination #

Patch Set 4 : Added workaround and TODO to investigate TurboFan issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -5 lines) Patch
M include/v8-debug.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M src/isolate.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 35 (15 generated)
Igor Sheludko
PTAL. Jochen - API, Toon - the rest.
4 years, 8 months ago (2016-03-29 15:10:43 UTC) #2
jochen (gone - plz use gerrit)
+yang/dimitri for their input https://codereview.chromium.org/1842763002/diff/1/include/v8-debug.h File include/v8-debug.h (right): https://codereview.chromium.org/1842763002/diff/1/include/v8-debug.h#newcode284 include/v8-debug.h:284: static void SetTailCallEliminationEnabled(Isolate* isolate, bool ...
4 years, 8 months ago (2016-03-29 15:12:15 UTC) #4
Igor Sheludko
+pfeldman https://codereview.chromium.org/1842763002/diff/1/include/v8-debug.h File include/v8-debug.h (right): https://codereview.chromium.org/1842763002/diff/1/include/v8-debug.h#newcode284 include/v8-debug.h:284: static void SetTailCallEliminationEnabled(Isolate* isolate, bool enabled); On 2016/03/29 ...
4 years, 8 months ago (2016-03-29 15:32:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842763002/20001
4 years, 8 months ago (2016-03-29 15:35:12 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15862)
4 years, 8 months ago (2016-03-29 15:50:59 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842763002/40001
4 years, 8 months ago (2016-03-29 16:52:10 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17660)
4 years, 8 months ago (2016-03-29 17:05:26 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842763002/60001
4 years, 8 months ago (2016-03-29 17:34:42 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 17:56:52 UTC) #19
Yang
On 2016/03/29 17:56:52, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-03-30 07:33:02 UTC) #20
Yang
On 2016/03/30 07:33:02, Yang wrote: > On 2016/03/29 17:56:52, commit-bot: I haz the power wrote: ...
4 years, 8 months ago (2016-03-30 07:38:55 UTC) #21
Benedikt Meurer
LGTM on compiler.
4 years, 8 months ago (2016-03-30 10:56:29 UTC) #23
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-03-30 10:59:15 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842763002/60001
4 years, 8 months ago (2016-03-30 11:02:42 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-03-30 11:04:29 UTC) #29
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/037f7f62159fe673e29d12419033ddc53ac5002e Cr-Commit-Position: refs/heads/master@{#35132}
4 years, 8 months ago (2016-03-30 11:05:27 UTC) #31
dgozman
On 2016/03/30 07:33:02, Yang wrote: > On 2016/03/29 17:56:52, commit-bot: I haz the power wrote: ...
4 years, 8 months ago (2016-03-30 16:51:00 UTC) #32
Yang
On 2016/03/30 16:51:00, dgozman wrote: > On 2016/03/30 07:33:02, Yang wrote: > > On 2016/03/29 ...
4 years, 8 months ago (2016-03-30 16:55:57 UTC) #33
Igor Sheludko
On 2016/03/30 16:51:00, dgozman wrote: > On 2016/03/30 07:33:02, Yang wrote: > > On 2016/03/29 ...
4 years, 8 months ago (2016-03-30 16:57:35 UTC) #34
pfeldman
4 years, 8 months ago (2016-03-30 17:31:47 UTC) #35
Message was sent while issue was closed.
> Now we have a separate switch for enabling/disabling TCO and DevTools could
use
> it to implement whatever logic is best for developers.

Exactly. dgozman@ does not have enough context for the matter, I'll bring him
up-to-date.

Powered by Google App Engine
This is Rietveld 408576698