Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1837513002: [es6] Add a flag to the Isolate that defines whether ES2015 tail call elimination is enabled or not. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Add a flag to the Isolate that defines whether ES2015 tail call elimination is enabled or not. Thus DevTools will be able to disable tail call elimination dynamically upon user's choice. BUG=v8:4698 LOG=N Committed: https://crrev.com/7a33bd5da48f6b7abdeeb013df360f1af84c06b7 Cr-Commit-Position: refs/heads/master@{#35098}

Patch Set 1 : Revert "[es6] Don't disable ES6 tail call elimination when Debugger is on." #

Patch Set 2 : New changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M src/arm/builtins-arm.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/assembler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/external-reference-table.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/isolate.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/s390/builtins-s390.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837513002/40001
4 years, 9 months ago (2016-03-25 16:20:53 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 16:51:34 UTC) #8
Igor Sheludko
PTAL
4 years, 8 months ago (2016-03-28 22:59:05 UTC) #10
Benedikt Meurer
LGTM.
4 years, 8 months ago (2016-03-29 04:17:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837513002/40001
4 years, 8 months ago (2016-03-29 10:31:07 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-03-29 11:43:52 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 11:44:50 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a33bd5da48f6b7abdeeb013df360f1af84c06b7
Cr-Commit-Position: refs/heads/master@{#35098}

Powered by Google App Engine
This is Rietveld 408576698