[Interpreter] Adds support to fetch return value on break at return.

[Interpreter] Adds support to fetch return value on break at return.

Debugger fetches the return value of a function when we break at return.
Interpreter holds the return value in accumulator. This is not stored in a
specified location on stack and hence it is not possible to look it up from
stack similar to full-codegen or optimized frames. This cl adds support to
store the value of accumulator on debug breaks. The value of accumulator is
passed to the runtime function and is then stored in thread local data.

Also changes full-codegen implementation to match that of ignition.
The return value from full-codegen is also stored in thread local data.
The return value is fetched directly thread local data instead of
finding it by iterating over frames.

BUG=v8:4280, v8:4690
LOG=N

Committed: https://crrev.com/b82720df34f078ec5e49ccee41e21e08b4862bdf
Cr-Commit-Position: refs/heads/master@{#35127}

[mythria, 2016-03-29 09:44:26]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 09:44:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842683002/1

[commit-bot: I haz the power, 2016-03-29 10:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 10:07:45]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-03-29 14:05:13]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 14:05:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842683002/20001

[mythria, 2016-03-29 14:28:32]

Description was changed from

==========
[Interpreter] Reland of Adds support to fetch return value on break at return.

Debugger fetches the return value of a function when we break at return.
Interpreter holds the return value in accumulator. This is not stored in a
specified location on stack and hence it is not possible to look it up from
stack similar to full-codegen or optimized frames. This cl adds support to
store the value of accumulator on debug breaks. The value of accumulator is
passed to the runtime function and is then stored in thread local data.

Also changes full-codegen implementation to match that of ignition.
The return value from full-codegen is also stored in thread local data.
The return value is fetched directly thread local data instead of
finding it by iterating over frames.

BUG=v8:4280, v8:4690
LOG=N
==========

to

==========
[Interpreter] Adds support to fetch return value on break at return.

Debugger fetches the return value of a function when we break at return.
Interpreter holds the return value in accumulator. This is not stored in a
specified location on stack and hence it is not possible to look it up from
stack similar to full-codegen or optimized frames. This cl adds support to
store the value of accumulator on debug breaks. The value of accumulator is
passed to the runtime function and is then stored in thread local data.

Also changes full-codegen implementation to match that of ignition.
The return value from full-codegen is also stored in thread local data.
The return value is fetched directly thread local data instead of
finding it by iterating over frames.

BUG=v8:4280, v8:4690
LOG=N
==========

[mythria, 2016-03-29 14:35:39]

mythria@chromium.org changed reviewers:
+ yangguo@chromium.org

[mythria, 2016-03-29 14:35:39]

There was a bug in the earlier implementation of this cl. It failed on
linux-nosnap-debug bots. I checked that the current implementation passes
linux-nosnap-debug. I fixed it in this cl. Please take a look. 

Thanks,
Mythri

[commit-bot: I haz the power, 2016-03-29 14:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 14:51:27]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-03-30 07:41:57]

On 2016/03/29 14:51:27, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

LGTM.

[mythria, 2016-03-30 07:56:19]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2016-03-30 07:56:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842683002/20001

[commit-bot: I haz the power, 2016-03-30 08:00:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 08:00:52]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12979)

[mythria, 2016-03-30 08:05:38]

mythria@chromium.org changed reviewers:
+ oth@chromium.org

[mythria, 2016-03-30 08:05:38]

Orion, 
could you please look at changes in interpreter.cc. I am trying to reland this
cl. The earlier cl was: https://codereview.chromium.org/1818873003/

[oth, 2016-03-30 08:40:56]

lgtm on Interpreter.

[mythria, 2016-03-30 08:49:14]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2016-03-30 08:49:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842683002/20001

[commit-bot: I haz the power, 2016-03-30 08:51:09]

Description was changed from

==========
[Interpreter] Adds support to fetch return value on break at return.

Debugger fetches the return value of a function when we break at return.
Interpreter holds the return value in accumulator. This is not stored in a
specified location on stack and hence it is not possible to look it up from
stack similar to full-codegen or optimized frames. This cl adds support to
store the value of accumulator on debug breaks. The value of accumulator is
passed to the runtime function and is then stored in thread local data.

Also changes full-codegen implementation to match that of ignition.
The return value from full-codegen is also stored in thread local data.
The return value is fetched directly thread local data instead of
finding it by iterating over frames.

BUG=v8:4280, v8:4690
LOG=N
==========

to

==========
[Interpreter] Adds support to fetch return value on break at return.

Debugger fetches the return value of a function when we break at return.
Interpreter holds the return value in accumulator. This is not stored in a
specified location on stack and hence it is not possible to look it up from
stack similar to full-codegen or optimized frames. This cl adds support to
store the value of accumulator on debug breaks. The value of accumulator is
passed to the runtime function and is then stored in thread local data.

Also changes full-codegen implementation to match that of ignition.
The return value from full-codegen is also stored in thread local data.
The return value is fetched directly thread local data instead of
finding it by iterating over frames.

BUG=v8:4280, v8:4690
LOG=N
==========

[commit-bot: I haz the power, 2016-03-30 08:51:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-30 08:52:16]

Description was changed from

==========
[Interpreter] Adds support to fetch return value on break at return.

Debugger fetches the return value of a function when we break at return.
Interpreter holds the return value in accumulator. This is not stored in a
specified location on stack and hence it is not possible to look it up from
stack similar to full-codegen or optimized frames. This cl adds support to
store the value of accumulator on debug breaks. The value of accumulator is
passed to the runtime function and is then stored in thread local data.

Also changes full-codegen implementation to match that of ignition.
The return value from full-codegen is also stored in thread local data.
The return value is fetched directly thread local data instead of
finding it by iterating over frames.

BUG=v8:4280, v8:4690
LOG=N
==========

to

==========
[Interpreter] Adds support to fetch return value on break at return.

Debugger fetches the return value of a function when we break at return.
Interpreter holds the return value in accumulator. This is not stored in a
specified location on stack and hence it is not possible to look it up from
stack similar to full-codegen or optimized frames. This cl adds support to
store the value of accumulator on debug breaks. The value of accumulator is
passed to the runtime function and is then stored in thread local data.

Also changes full-codegen implementation to match that of ignition.
The return value from full-codegen is also stored in thread local data.
The return value is fetched directly thread local data instead of
finding it by iterating over frames.

BUG=v8:4280, v8:4690
LOG=N

Committed: https://crrev.com/b82720df34f078ec5e49ccee41e21e08b4862bdf
Cr-Commit-Position: refs/heads/master@{#35127}
==========

[commit-bot: I haz the power, 2016-03-30 08:52:17]

Patchset 2 (id:??) landed as
https://crrev.com/b82720df34f078ec5e49ccee41e21e08b4862bdf
Cr-Commit-Position: refs/heads/master@{#35127}