Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 184253004: gin: Bug fix: Fix CreateHandle to return an emtpy handle in some extreme cases (Closed)

Created:
6 years, 9 months ago by hajimehoshi
Modified:
6 years, 9 months ago
CC:
chromium-reviews, haraken, kouhei (in TOK)
Visibility:
Public.

Description

gin: Bug fix: Fix CreateHandle to return an emtpy handle in some extreme cases In some extreme cases, ObjectTemplate::NewInstance might return an empty handler. For example, the getter and setter Object.prototype.constructor can be rewritten with a evil function which can throw exceptions. BUG=331301 TEST=gin_unittests --gtest_filter=WrappableTest.ErrorInObjectConstructorProperty Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254109

Patch Set 1 #

Patch Set 2 : Bug fix: remove an extra include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M gin/handle.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M gin/wrappable.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M gin/wrappable_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hajimehoshi
PTAL
6 years, 9 months ago (2014-02-28 08:53:56 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-02-28 09:04:18 UTC) #2
hajimehoshi
The CQ bit was checked by hajimehoshi@chromium.org
6 years, 9 months ago (2014-02-28 09:06:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/184253004/20001
6 years, 9 months ago (2014-02-28 09:06:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 10:18:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-02-28 10:18:07 UTC) #6
hajimehoshi
The CQ bit was checked by hajimehoshi@chromium.org
6 years, 9 months ago (2014-02-28 10:26:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/184253004/20001
6 years, 9 months ago (2014-02-28 10:27:55 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 14:48:26 UTC) #9
Message was sent while issue was closed.
Change committed as 254109

Powered by Google App Engine
This is Rietveld 408576698