gin: Bug fix: Fix CreateHandle to return an emtpy handle in some extreme cases

gin/wrappable_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "gin/arguments.h"
 #include "gin/handle.h"
 #include "gin/object_template_builder.h"
 #include "gin/per_isolate_data.h"
 #include "gin/public/isolate_holder.h"
@@ skipping 173 matching lines @@
   v8::Handle<v8::Function> func;
   EXPECT_TRUE(ConvertFromV8(isolate, val, &func));
   v8::Handle<v8::Value> argv[] = {
     ConvertToV8(isolate, object.get())
   };
   func->Call(v8::Undefined(isolate), 1, argv);
   EXPECT_FALSE(try_catch.HasCaught());
   EXPECT_EQ("Hello, Lily", object->result);
 }
 
+TEST_F(WrappableTest, ErrorInObjectConstructorProperty) {
+  v8::Isolate* isolate = instance_->isolate();
+  v8::HandleScope handle_scope(isolate);
+
+  v8::Handle<v8::String> source = StringToV8(
+      isolate,
+      "(function() {"
+      "  Object.defineProperty(Object.prototype, 'constructor', {"
+      "    get: function() { throw 'Error'; },"
+      "    set: function() { throw 'Error'; }"
+      "  });"
+      "})();");
+  EXPECT_FALSE(source.IsEmpty());
+  v8::Handle<v8::Script> script = v8::Script::New(source);
+  script->Run();
+
+  gin::TryCatch try_catch;
+  gin::Handle<MyObject> obj = MyObject::Create(isolate);
+  EXPECT_TRUE(obj.IsEmpty());
+  EXPECT_TRUE(try_catch.HasCaught());
+}
+
 }  // namespace gin