blimp/client/session/blimp_client_session.h - Issue 1842403003: Added Version Info page to toolbar menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 1842403003: Added Version Info page to toolbar menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@toolbar_menu

Patch Set: Addressed review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/session/blimp_client_session.h

diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h

index d69bc3948666fe1b3f267f37d3beb6bdb1732104..da41761926291db59c163a24c07915ccf4c18d3a 100644

--- a/blimp/client/session/blimp_client_session.h

+++ b/blimp/client/session/blimp_client_session.h

@@ -81,7 +81,8 @@ class BLIMP_CLIENT_EXPORT BlimpClientSession : public NetworkEventObserver {

// Notified every time the AssignmentSource returns the result of an attempted

// assignment request.

- virtual void OnAssignmentConnectionAttempted(AssignmentSource::Result result);

+ virtual void OnAssignmentConnectionAttempted(AssignmentSource::Result result,

+ const Assignment& assignment);

private:

void RegisterFeatures();