Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2407)

Unified Diff: blimp/client/session/blimp_client_session.cc

Issue 1842403003: Added Version Info page to toolbar menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@toolbar_menu
Patch Set: Addressed review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/session/blimp_client_session.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/session/blimp_client_session.cc
diff --git a/blimp/client/session/blimp_client_session.cc b/blimp/client/session/blimp_client_session.cc
index ebc9d1bd4ec689cc98d823160ebfc94654d5b488..711f29442bac5ac7ceb1eb3b7b7975093feafa1e 100644
--- a/blimp/client/session/blimp_client_session.cc
+++ b/blimp/client/session/blimp_client_session.cc
@@ -190,7 +190,7 @@ void BlimpClientSession::Connect(const std::string& client_auth_token) {
void BlimpClientSession::ConnectWithAssignment(AssignmentSource::Result result,
const Assignment& assignment) {
- OnAssignmentConnectionAttempted(result);
+ OnAssignmentConnectionAttempted(result, assignment);
if (result != AssignmentSource::Result::RESULT_OK) {
VLOG(1) << "Assignment request failed: " << result;
@@ -204,7 +204,8 @@ void BlimpClientSession::ConnectWithAssignment(AssignmentSource::Result result,
}
void BlimpClientSession::OnAssignmentConnectionAttempted(
- AssignmentSource::Result result) {}
+ AssignmentSource::Result result,
+ const Assignment& assignment) {}
void BlimpClientSession::RegisterFeatures() {
thread_pipe_manager_ = base::WrapUnique(new ThreadPipeManager(
« no previous file with comments | « blimp/client/session/blimp_client_session.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698