blimp/client/session/blimp_client_session.h - Issue 1842403003: Added Version Info page to toolbar menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 1842403003: Added Version Info page to toolbar menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@toolbar_menu

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/session/blimp_client_session.h

diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h

index 5cfdd9ef7293118a7cd8797f66c00752d3da883a..127e3d1891903796557861d2cc15bf32c1951c5f 100644

--- a/blimp/client/session/blimp_client_session.h

+++ b/blimp/client/session/blimp_client_session.h

@@ -82,6 +82,9 @@ class BLIMP_CLIENT_EXPORT BlimpClientSession : public NetworkEventObserver {

// assignment request.

virtual void OnAssignmentConnectionAttempted(AssignmentSource::Result result);

+ std::string engineIPAddress_;

Kevin M 2016/03/31 19:41:49 Make the fields private and add a public or protec

shaktisahu 2016/04/06 06:50:25 Acknowledged. Moved these out of BlimpClientSessio

+ std::string engineVersion_;

private:

void RegisterFeatures();