Added Version Info page to toolbar menu

blimp/client/session/blimp_client_session.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
 #define BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 64 matching lines @@
   virtual void ConnectWithAssignment(AssignmentSource::Result result,
                                      const Assignment& assignment);
 
  protected:
   ~BlimpClientSession() override;
 
   // Notified every time the AssignmentSource returns the result of an attempted
   // assignment request.
   virtual void OnAssignmentConnectionAttempted(AssignmentSource::Result result);
 
+  std::string engineIPAddress_;

[Kevin M, 2016/03/31 19:41:49]

Make the fields private and add a public or protected const getter.

Can we just store the Assignment object directly?

[shaktisahu, 2016/04/06 06:50:25]

Acknowledged.
Moved these out of BlimpClientSession.

+  std::string engineVersion_;
+
  private:
   void RegisterFeatures();
 
   // NetworkEventObserver implementation.
   void OnConnected() override;
   void OnDisconnected(int result) override;
 
   base::Thread io_thread_;
   scoped_ptr<TabControlFeature> tab_control_feature_;
   scoped_ptr<NavigationFeature> navigation_feature_;
@@ skipping 13 matching lines @@
 
   base::WeakPtrFactory<BlimpClientSession> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpClientSession);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_SESSION_BLIMP_CLIENT_SESSION_H_